From: Nick Piggin <npiggin@suse•de>
To: David Rientjes <rientjes@google•com>
Cc: linux-arch@vger•kernel.org, linuxppc-dev@ozlabs•org,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [patch 11/14] powerpc: invoke oom-killer from page fault
Date: Fri, 23 Apr 2010 20:27:42 +1000 [thread overview]
Message-ID: <20100423102742.GC5683@laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1004221442590.25350@chino.kir.corp.google.com>
On Thu, Apr 22, 2010 at 02:44:22PM -0700, David Rientjes wrote:
> On Fri, 23 Apr 2010, npiggin@suse•de wrote:
>
> > As explained in commit 1c0fe6e3bd, we want to call the architecture independent
> > oom killer when getting an unexplained OOM from handle_mm_fault, rather than
> > simply killing current.
> >
> > Cc: linuxppc-dev@ozlabs•org
> > Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > Cc: linux-arch@vger•kernel.org
> > Signed-off-by: Nick Piggin <npiggin@suse•de>
> > ---
> > Index: linux-2.6/arch/powerpc/mm/fault.c
> > ===================================================================
> > --- linux-2.6.orig/arch/powerpc/mm/fault.c
> > +++ linux-2.6/arch/powerpc/mm/fault.c
> > @@ -359,15 +359,10 @@ bad_area_nosemaphore:
> > */
> > out_of_memory:
> > up_read(&mm->mmap_sem);
> > - if (is_global_init(current)) {
> > - yield();
> > - down_read(&mm->mmap_sem);
> > - goto survive;
> > - }
> > - printk("VM: killing process %s\n", current->comm);
> > - if (user_mode(regs))
> > - do_group_exit(SIGKILL);
> > - return SIGKILL;
> > + if (!user_mode(regs))
> > + return SIGKILL;
> > + pagefault_out_of_memory();
> > + return 0;
>
> Do we really want to return 0 and indicate that the fault was handled? It
> seems more consistent to do
>
> if (user_mode(regs))
> pagefault_out_of_memory();
> return SIGKILL;
Well we don't necessarily want to kill current.
pagefault_out_of_memory() could elect to send a SIGKILL if wants to, but
if it decides current should not be terminated, then we have to just
retry the page fault.
prev parent reply other threads:[~2010-04-23 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100422160613.723698029@suse.de>
2010-04-22 16:06 ` [patch 11/14] powerpc: invoke oom-killer from page fault npiggin
2010-04-22 21:44 ` David Rientjes
2010-04-23 10:27 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423102742.GC5683@laptop \
--to=npiggin@suse$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=rientjes@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox