From: Mark Brown <broonie@opensource•wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix•de>
Cc: Greg Kroah-Hartman <gregkh@suse•de>,
linuxppc-dev@ozlabs•org, linux-mtd@lists•infradead.org,
linux-i2c@vger•kernel.org, devel@driverdev•osuosl.org,
Samuel Ortiz <sameo@linux•intel.com>,
lm-sensors@lm-sensors•org, linux-input@vger•kernel.org,
linux-media@vger•kernel.org,
Paul Gortmaker <p_gortmaker@yahoo•com>,
Riku Voipio <riku.voipio@iki•fi>,
rtc-linux@googlegroups•com,
Alessandro Rubini <rubini@ipvvis•unipv.it>,
Mauro Carvalho Chehab <mchehab@infradead•org>,
Jean Delvare <khali@linux-fr•org>,
"Ben Dooks \(embedded platforms\)" <ben-linux@fluff•org>,
Liam Girdwood <lrg@slimlogic•co.uk>,
Alessandro Zummo <a.zummo@towertech•it>,
Guillaume Ligneul <guillaume.ligneul@gmail•com>,
George Joseph <george.joseph@fairview5•com>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
linux-kernel@vger•kernel.org, Richard Purdie <rpurdie@rpsys•net>,
Colin Leroy <colin@colino•net>,
David Woodhouse <dwmw2@infradead•org>
Subject: Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)
Date: Mon, 31 May 2010 14:01:58 +0100 [thread overview]
Message-ID: <20100531130157.GA10507@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1275310552-14685-1-git-send-email-w.sang@pengutronix.de>
On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote:
> I2C-drivers can use the clientdata-pointer to point to private data. As I2C
> devices are not really unregistered, but merely detached from their driver, it
> used to be the drivers obligation to clear this pointer during remove() or a
> failed probe(). As a couple of drivers forgot to do this, it was agreed that it
> was cleaner if the i2c-core does this clearance when appropriate, as there is
> no guarantee for the lifetime of the clientdata-pointer after remove() anyhow.
> This feature was added to the core with commit
> e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.
>
> As there is no need anymore to clear the clientdata-pointer, remove all current
> occurrences in the drivers to simplify the code and prevent confusion.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix•de>
Acked-by: Mark Brown <broonie@opensource•wolfsonmicro.com>
next prev parent reply other threads:[~2010-05-31 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 12:55 [PATCH] drivers: remove all i2c_set_clientdata(client, NULL) Wolfram Sang
2010-05-31 13:01 ` Mark Brown [this message]
2010-05-31 16:54 ` Greg KH
2010-05-31 19:09 ` Dmitry Torokhov
2010-05-31 20:57 ` Jean Delvare
2010-05-31 21:48 ` Richard Purdie
2010-06-01 5:05 ` Dmitry Torokhov
2010-06-01 13:53 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531130157.GA10507@rakim.wolfsonmicro.main \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=a.zummo@towertech$(echo .)it \
--cc=ben-linux@fluff$(echo .)org \
--cc=colin@colino$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=george.joseph@fairview5$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=guillaume.ligneul@gmail$(echo .)com \
--cc=khali@linux-fr$(echo .)org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=lm-sensors@lm-sensors$(echo .)org \
--cc=lrg@slimlogic$(echo .)co.uk \
--cc=mchehab@infradead$(echo .)org \
--cc=p_gortmaker@yahoo$(echo .)com \
--cc=riku.voipio@iki$(echo .)fi \
--cc=rpurdie@rpsys$(echo .)net \
--cc=rtc-linux@googlegroups$(echo .)com \
--cc=rubini@ipvvis$(echo .)unipv.it \
--cc=sameo@linux$(echo .)intel.com \
--cc=w.sang@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox