public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle•de>
To: linuxppc-dev@ozlabs•org,
	Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: stable@kernel•org
Subject: [PATCH] [powerpc] do not expect executable permissions for in-tree shell scripts
Date: Sat, 5 Jun 2010 10:10:39 +0200	[thread overview]
Message-ID: <20100605081039.GA21300@aepfle.de> (raw)


scripts in the kernel source do not have executable permissions if they were created with patch(1)
run mkuboot.sh with bash, its tagged as bash script.

/opt/cross/kernel/linux-2.6.33-cross-host-kernel-source/arch/powerpc/boot/wrapper: line 273: /opt/cross/kernel/linux-2.6.33-cross-host-kernel-source/scripts/mkuboot.sh: Permission denied

Signed-off-by: Olaf Hering <olaf@aepfle•de>

---

This happens with 2.6.33, other versions have this bug as well.

 arch/powerpc/boot/wrapper |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.33-cross-host-kernel-source.orig/arch/powerpc/boot/wrapper
+++ linux-2.6.33-cross-host-kernel-source/arch/powerpc/boot/wrapper
@@ -270,7 +270,7 @@ membase=`${CROSS}objdump -p "$kernel" |
 case "$platform" in
 uboot)
     rm -f "$ofile"
-    ${MKIMAGE} -A ppc -O linux -T kernel -C gzip -a $membase -e $membase \
+    bash ${MKIMAGE} -A ppc -O linux -T kernel -C gzip -a $membase -e $membase \
 	$uboot_version -d "$vmz" "$ofile"
     if [ -z "$cacheit" ]; then
 	rm -f "$vmz"
@@ -330,7 +330,7 @@ coff)
     ;;
 cuboot*)
     gzip -f -9 "$ofile"
-    ${MKIMAGE} -A ppc -O linux -T kernel -C gzip -a "$base" -e "$entry" \
+    bash ${MKIMAGE} -A ppc -O linux -T kernel -C gzip -a "$base" -e "$entry" \
             $uboot_version -d "$ofile".gz "$ofile"
     ;;
 treeboot*)

             reply	other threads:[~2010-06-05  8:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05  8:10 Olaf Hering [this message]
2010-06-05 17:32 ` [PATCH] [powerpc] do not expect executable permissions for in-tree shell scripts Sean MacLennan
2010-06-05 17:44   ` Olaf Hering
2010-06-05 18:00     ` Sean MacLennan
2010-06-10  6:26       ` Benjamin Herrenschmidt
2010-06-10 15:20         ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100605081039.GA21300@aepfle.de \
    --to=olaf@aepfle$(echo .)de \
    --cc=benh@kernel$(echo .)crashing.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=stable@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox