Subject: Re: [PATCH] powerpc: rtas_flash cannot be a module

From: Milton Miller <[email-masked]>
Date: Wed, 9 Jun 2010 16:01:10 +1000

On Wed, 9 Jun 2010 at about 16:01:10 +1000 Anton Blanchard wrote:
> 
> When trying to flash a machine via the update_flash command, I received the
> following error:
> 
> 
>     Restarting system.
>     FLASH: kernel bug...flash list header addr above 4GB
> 
> 
> The code in question has a comment that the flash list should be in
> the kernel data and therefore under 4GB:
> 
>         /* NOTE: the "first" block list is a global var with no data
>          * blocks in the kernel data segment.  We do this because
>          * we want to ensure this block_list addr is under 4GB.
>          */
> 
> Unfortunately the Kconfig option is marked tristate which means the variable
> may not be in the kernel data and could be above 4GB.

So we should use that rtas_data_buf with its lock ...

Oh look, the driver already uses that buffer for the call to verify_flash

untested patch to follow

milton