From: "Paul E. McKenney" <paulmck@linux•vnet.ibm.com>
To: Michael Neuling <mikey@neuling•org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH RFC] ppc: fix default_machine_crash_shutdown #ifdef botch
Date: Wed, 16 Jun 2010 21:30:39 -0700 [thread overview]
Message-ID: <20100617043038.GA2651@linux.vnet.ibm.com> (raw)
In-Reply-To: <6286.1276739813@neuling.org>
On Thu, Jun 17, 2010 at 11:56:53AM +1000, Michael Neuling wrote:
>
>
> In message <20100616004839.GA18110@linux•vnet.ibm.com> you wrote:
> > crash_kexec_wait_realmode() is defined only if CONFIG_PPC_STD_MMU_64
> > and CONFIG_SMP, but is called if CONFIG_PPC_STD_MMU_64 even if !CONFIG_SMP.
> > Fix the conditional compilation around the invocation.
> >
> > Untested, probably does not compile.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux•vnet.ibm.com>
>
> This should be right since we don't need to wait for the other CPUs if
> there are no others...
>
> Compiles for me and even fixes the SMP=N case. Thanks!
Glad it worked! ;-)
Thanx, Paul
> Acked-by: Michael Neuling <mikey@neuling•org>
>
> > ---
> >
> > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> > index b46f2e0..29df48f 100644
> > --- a/arch/powerpc/kernel/crash.c
> > +++ b/arch/powerpc/kernel/crash.c
> > @@ -447,7 +447,7 @@ void default_machine_crash_shutdown(struct pt_regs *regs)
> > crash_kexec_prepare_cpus(crashing_cpu);
> > cpu_set(crashing_cpu, cpus_in_crash);
> > crash_kexec_stop_spus();
> > -#ifdef CONFIG_PPC_STD_MMU_64
> > +#if defined(CONFIG_PPC_STD_MMU_64) && defined(CONFIG_SMP)
> > crash_kexec_wait_realmode(crashing_cpu);
> > #endif
> > if (ppc_md.kexec_cpu_down)
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists•ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
> >
prev parent reply other threads:[~2010-06-17 4:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 0:48 [PATCH RFC] ppc: fix default_machine_crash_shutdown #ifdef botch Paul E. McKenney
2010-06-17 1:56 ` Michael Neuling
2010-06-17 4:30 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617043038.GA2651@linux.vnet.ibm.com \
--to=paulmck@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox