From: Arnd Bergmann <arnd@arndb•de>
To: Jeremy Kerr <jk@ozlabs•org>
Cc: John Kacur <jkacur@redhat•com>,
Frederic Weisbecker <fweisbec@gmail•com>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Christoph Hellwig <hch@lst•de>
Subject: Re: [PATCH 06/18] spufs: use llseek in all file operations
Date: Thu, 8 Jul 2010 15:02:36 +0200 [thread overview]
Message-ID: <201007081502.37133.arnd@arndb.de> (raw)
In-Reply-To: <1278551728.28333.55.camel@pororo.lan>
On Thursday 08 July 2010, Jeremy Kerr wrote:
> > @@ -2151,7 +2166,7 @@ static ssize_t spufs_ibox_info_read(struct file *file, char __user *buf,
> > static const struct file_operations spufs_ibox_info_fops = {
> > .open = spufs_info_open,
> > .read = spufs_ibox_info_read,
> > - .llseek = generic_file_llseek,
> > + .llseek = no_llseek,
> > };
> >
> > static ssize_t __spufs_wbox_info_read(struct spu_context *ctx,
> > @@ -2194,7 +2209,7 @@ static ssize_t spufs_wbox_info_read(struct file *file, char __user *buf,
> > static const struct file_operations spufs_wbox_info_fops = {
> > .open = spufs_info_open,
> > .read = spufs_wbox_info_read,
> > - .llseek = generic_file_llseek,
> > + .llseek = no_llseek,
> > };
> >
>
> Why the change in behaviour for the mbox info files?
>
D'oh, that wasn't intentional. I guess what must have happened is that I first
added generic_file_llseek to all file_operations in spufs and then made up my
mind and chose what I thought was correct in each case, which broke these.
Of course, these *_info_fops should be seekable.
Arnd
next prev parent reply other threads:[~2010-07-08 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1278538820-1392-1-git-send-email-arnd@arndb.de>
2010-07-07 21:40 ` [PATCH 06/18] spufs: use llseek in all file operations Arnd Bergmann
2010-07-08 1:15 ` Jeremy Kerr
2010-07-08 13:02 ` Arnd Bergmann [this message]
2010-07-08 13:29 ` [PATCH v2] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007081502.37133.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=fweisbec@gmail$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=jk@ozlabs$(echo .)org \
--cc=jkacur@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox