From: Greg KH <gregkh@suse•de>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Nick Cheng <nick.cheng@areca•com.tw>,
Linus Walleij <linus.walleij@stericsson•com>,
James Smart <james.smart@emulex•com>,
linuxppc-dev@ozlabs•org,
"Eric W. Biederman" <ebiederm@aristanetworks•com>,
Dmitry Torokhov <dtor@mail•ru>,
Benjamin Thery <benjamin.thery@bull•net>,
Mark Brown <broonie@opensource•wolfsonmicro.com>,
linux-kernel@vger•kernel.org, Chris Wright <chrisw@sous-sol•org>,
Jean Delvare <khali@linux-fr•org>,
"James E.J. Bottomley" <James.Bottomley@suse•de>,
Paul Mackerras <paulus@samba•org>,
Alex Iannicelli <alex.iannicelli@emulex•com>,
Jani Nikula <ext-jani.1.nikula@nokia•com>,
Tejun Heo <tj@kernel•org>, Richard Purdie <rpurdie@rpsys•net>,
Liam Girdwood <lrg@slimlogic•co.uk>,
linux-scsi@vger•kernel.org,
Guenter Roeck <guenter.roeck@ericsson•com>
Subject: Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
Date: Fri, 30 Jul 2010 07:36:22 -0700 [thread overview]
Message-ID: <20100730143622.GA30105@suse.de> (raw)
In-Reply-To: <1280485690.1902.8.camel@pasglop>
On Fri, Jul 30, 2010 at 08:28:10PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2010-07-30 at 10:45 +0200, Tejun Heo wrote:
> > On 07/29/2010 07:09 AM, Guenter Roeck wrote:
> > > The following comment is found in include/linux/sysfs.h:
> > >
> > > /* FIXME
> > > * The *owner field is no longer used.
> > > * x86 tree has been cleaned up. The owner
> > > * attribute is still left for other arches.
> > > */
> > >
> > > As it turns out, the *owner field is (again?) initialized in several modules,
> > > suggesting that such initialization may be creeping back into the code.
> > >
> > > This patch set removes the above comment, the *owner field, and each instance
> > > in the code where it was found to be initialized.
> > >
> > > Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc,
> > > and sparc defconfig builds.
> >
> > Yeah, the change is way overdue. Maybe we should have just removed
> > them back then.
>
> I'm happy with the powerpc related patches as long as we all agree that
> needs to go. Do you need me to put some of this in powerpc.git or are
> you carrying them all to Linus ?
I can carry them all in my driver-core tree if you don't object.
thanks,
greg k-h
next prev parent reply other threads:[~2010-07-30 14:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 5:09 [PATCH 0/6] Remove owner field from sysfs attribute structure Guenter Roeck
2010-07-29 5:09 ` [PATCH 1/6] scsi: Remove owner field from attribute initialization in LPFC driver Guenter Roeck
2010-07-29 5:09 ` [PATCH 2/6] scsi: Remove owner field from attribute initialization in ARCMSR driver Guenter Roeck
2010-07-29 5:09 ` [PATCH 3/6] leds: Remove owner field from attribute initialization in bd2802 driver Guenter Roeck
2010-07-29 5:09 ` [PATCH 5/6] powerpc/pci: Remove owner field from attribute initialization in PCI bridge init Guenter Roeck
2010-07-29 5:09 ` [PATCH 6/6] Remove owner field from sysfs struct attribute Guenter Roeck
2010-07-29 6:16 ` [PATCH 0/6] Remove owner field from sysfs attribute structure Eric Biederman
2010-08-02 23:31 ` Greg KH
2010-08-10 13:43 ` Jean Delvare
2010-08-10 15:17 ` Stephen Rothwell
2010-08-10 15:20 ` Stephen Rothwell
2010-08-10 16:43 ` Guenter Roeck
[not found] ` <1280380166-29196-5-git-send-email-guenter.roeck@ericsson.com>
2010-07-29 17:15 ` [PATCH 4/6] regulator: Remove owner field from attribute initialization in regulator core driver Mark Brown
2010-07-30 8:45 ` [PATCH 0/6] Remove owner field from sysfs attribute structure Tejun Heo
2010-07-30 10:28 ` Benjamin Herrenschmidt
2010-07-30 14:36 ` Greg KH [this message]
2010-08-02 16:15 ` Guenter Roeck
2010-08-02 16:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730143622.GA30105@suse.de \
--to=gregkh@suse$(echo .)de \
--cc=James.Bottomley@suse$(echo .)de \
--cc=alex.iannicelli@emulex$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=benjamin.thery@bull$(echo .)net \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=chrisw@sous-sol$(echo .)org \
--cc=dtor@mail$(echo .)ru \
--cc=ebiederm@aristanetworks$(echo .)com \
--cc=ext-jani.1.nikula@nokia$(echo .)com \
--cc=guenter.roeck@ericsson$(echo .)com \
--cc=james.smart@emulex$(echo .)com \
--cc=khali@linux-fr$(echo .)org \
--cc=linus.walleij@stericsson$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=lrg@slimlogic$(echo .)co.uk \
--cc=nick.cheng@areca$(echo .)com.tw \
--cc=paulus@samba$(echo .)org \
--cc=rpurdie@rpsys$(echo .)net \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox