From: Greg KH <gregkh@suse•de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>
Cc: "Cliff Cai" <cliff.cai@analog•com>,
"Mark Brown" <broonie@opensource•wolfsonmicro.com>,
"Dinh Nguyen" <Dinh.Nguyen@freescale•com>,
"Takashi Iwai" <tiwai@suse•de>,
"Nicolas Ferre" <nicolas.ferre@atmel•com>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
"Julia Lawall" <julia@diku•dk>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard•com>,
"Philipp Zabel" <philipp.zabel@gmail•com>,
"Felipe Balbi" <felipe.balbi@nokia•com>,
"Andrea Gelmini" <andrea.gelmini@gelma•net>,
"Robert Jarzmik" <robert.jarzmik@free•fr>,
"Fabien Chouteau" <fabien.chouteau@barco•com>,
"Dan Carpenter" <error27@gmail•com>,
"FUJITA Tomonori" <fujita.tomonori@lab•ntt.co.jp>,
"David Brownell" <dbrownell@users•sourceforge.net>,
"Vladimir Zapolskiy" <vzapolskiy@gmail•com>,
"Sergei Shtylyov" <sshtylyov@ru•mvista.com>,
"Vincent Sanders" <support@simtec•co.uk>,
"Marc Singer" <elf@buici•com>,
"David Brownell" <david-b@pacbell•net>,
"Tony Lindgren" <tony@atomide•com>,
"André Goddard Rosa" <andre.goddard@gmail•com>,
"Alan Stern" <stern@rowland•harvard.edu>,
"Sean MacLennan" <smaclennan@pikatech•com>,
"Russell King" <rmk+kernel@arm•linux.org.uk>,
"Tobias Klauser" <tklauser@distanz•ch>,
"Anatolij Gustschin" <agust@denx•de>,
"Alexey Dobriyan" <adobriyan@gmail•com>,
"Eirik Aanonsen" <eaa@wprmedical•com>,
"Mike Frysinger" <vapier@gentoo•org>,
"Thomas Dahlmann" <dahlmann.thomas@arcor•de>,
linux-geode@lists•infradead.org,
"Ben Dooks" <ben-linux@fluff•org>,
"Magnus Damm" <damm@igel•co.jp>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Anton Vorontsov" <avorontsov@ru•mvista.com>,
"Andrew Victor" <linux@maxim•org.za>,
linux-arm-kernel@lists•infradead.org,
"Robert Lukassen" <robert.lukassen@tomtom•com>,
"Eric Miao" <eric.y.miao@gmail•com>,
"Németh Márton" <nm127@freemail•hu>,
"Jiri Kosina" <jkosina@suse•cz>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas•com>,
linux-usb@vger•kernel.org,
"Michał Nazarewicz" <m.nazarewicz@samsung•com>,
"Harro Haan" <hrhaan@gmail•com>,
"Kyle McMartin" <kyle@mcmartin•ca>,
"H Hartley Sweeten" <hsweeten@visionengravers•com>,
"Paul Mundt" <lethal@linux-sh•org>, "Tejun Heo" <tj@kernel•org>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Cory Maccarrone" <darkstar6262@gmail•com>
Subject: Re: [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver
Date: Mon, 2 Aug 2010 15:54:40 -0700 [thread overview]
Message-ID: <20100802225440.GA9190@suse.de> (raw)
In-Reply-To: <20100802131248.GD13900@pengutronix.de>
On Mon, Aug 02, 2010 at 03:12:48PM +0200, Uwe Kleine-König wrote:
> On Mon, Aug 02, 2010 at 02:51:36PM +0200, Julia Lawall wrote:
> > > diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> > > index 731150d..c266c1e 100644
> > > --- a/drivers/usb/gadget/amd5536udc.c
> > > +++ b/drivers/usb/gadget/amd5536udc.c
> > > @@ -1954,13 +1954,14 @@ static int setup_ep0(struct udc *dev)
> > > }
> > >
> > > /* Called by gadget driver to register itself */
> > > -int usb_gadget_register_driver(struct usb_gadget_driver *driver)
> > > +int usb_gadget_probe_driver(struct usb_gadget_driver *driver,
> > > + int (*bind)(struct usb_gadget *))
> > > {
> > > struct udc *dev = udc;
> > > int retval;
> > > u32 tmp;
> > >
> > > - if (!driver || !driver->bind || !driver->setup
> > > + if (!driver || bind || !driver->setup
> >
> > I have the impression that this should be !bind rather than bind.
> ah, now I see what you meant. Obviously you're right. I fixed it up
> locally here for now. Greg, just tell me when/if you need a fixed
> patch.
Didn't you already post a "fixed" patch?
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-02 22:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 14:49 [PATCH RFC] usb gadget: introduce usb_gadget_probe_driver Uwe Kleine-König
2010-07-30 15:14 ` Julia Lawall
2010-07-30 15:28 ` Uwe Kleine-König
2010-07-30 15:16 ` Michał Nazarewicz
2010-07-30 15:26 ` Uwe Kleine-König
2010-07-30 16:08 ` Michał Nazarewicz
2010-07-30 18:57 ` Uwe Kleine-König
2010-07-30 18:46 ` David Brownell
2010-08-02 9:39 ` Michał Nazarewicz
2010-08-02 12:39 ` [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver Uwe Kleine-König
2010-08-02 12:51 ` Julia Lawall
2010-08-02 13:12 ` Uwe Kleine-König
2010-08-02 22:54 ` Greg KH [this message]
2010-08-02 14:25 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802225440.GA9190@suse.de \
--to=gregkh@suse$(echo .)de \
--cc=Dinh.Nguyen@freescale$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=agust@denx$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andre.goddard@gmail$(echo .)com \
--cc=andrea.gelmini@gelma$(echo .)net \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=ben-linux@fluff$(echo .)org \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=cliff.cai@analog$(echo .)com \
--cc=dahlmann.thomas@arcor$(echo .)de \
--cc=damm@igel$(echo .)co.jp \
--cc=darkstar6262@gmail$(echo .)com \
--cc=david-b@pacbell$(echo .)net \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=eaa@wprmedical$(echo .)com \
--cc=elf@buici$(echo .)com \
--cc=eric.y.miao@gmail$(echo .)com \
--cc=error27@gmail$(echo .)com \
--cc=fabien.chouteau@barco$(echo .)com \
--cc=felipe.balbi@nokia$(echo .)com \
--cc=fujita.tomonori@lab$(echo .)ntt.co.jp \
--cc=hrhaan@gmail$(echo .)com \
--cc=hsweeten@visionengravers$(echo .)com \
--cc=jkosina@suse$(echo .)cz \
--cc=julia@diku$(echo .)dk \
--cc=kyle@mcmartin$(echo .)ca \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-geode@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux@maxim$(echo .)org.za \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=m.nazarewicz@samsung$(echo .)com \
--cc=nicolas.ferre@atmel$(echo .)com \
--cc=nm127@freemail$(echo .)hu \
--cc=philipp.zabel@gmail$(echo .)com \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=robert.jarzmik@free$(echo .)fr \
--cc=robert.lukassen@tomtom$(echo .)com \
--cc=smaclennan@pikatech$(echo .)com \
--cc=sshtylyov@ru$(echo .)mvista.com \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=support@simtec$(echo .)co.uk \
--cc=tglx@linutronix$(echo .)de \
--cc=tiwai@suse$(echo .)de \
--cc=tj@kernel$(echo .)org \
--cc=tklauser@distanz$(echo .)ch \
--cc=tony@atomide$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=vapier@gentoo$(echo .)org \
--cc=vzapolskiy@gmail$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox