From: Grant Likely <grant.likely@secretlab•ca>
To: Mingkai Hu <Mingkai.hu@freescale•com>,
David Woodhouse <dwmw2@infradead•org>
Cc: kumar.gala@freescale•com, david-b@pacbell•net,
linuxppc-dev@ozlabs•org, linux-mtd@lists•infradead.org,
spi-devel-general@lists•sourceforge.net
Subject: Re: [PATCH v4 5/5] mtd: m25p80: add support to parse the partitions by OF node
Date: Tue, 12 Oct 2010 21:44:37 -0600 [thread overview]
Message-ID: <20101013034437.GE7254@angua.secretlab.ca> (raw)
In-Reply-To: <1286878714-13090-6-git-send-email-Mingkai.hu@freescale.com>
On Tue, Oct 12, 2010 at 06:18:34PM +0800, Mingkai Hu wrote:
> Signed-off-by: Mingkai Hu <Mingkai.hu@freescale•com>
> Acked-by: Grant Likely <grant.likely@secretlab•ca>
dwmw2: what are your thoughts on this one?
g.
> ---
> v4:
> - Updated to latest kernel base(Linux 2.6.36-rc7).
> - Made changes according to Grant's comments.
>
> drivers/mtd/devices/m25p80.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 6f512b5..9d20738 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -924,6 +924,11 @@ static int __devinit m25p_probe(struct spi_device *spi)
> nr_parts = data->nr_parts;
> }
>
> + if (nr_parts <= 0 && spi->dev.of_node) {
> + nr_parts = of_mtd_parse_partitions(&spi->dev,
> + spi->dev.of_node, &parts);
> + }
> +
> if (nr_parts > 0) {
> for (i = 0; i < nr_parts; i++) {
> DEBUG(MTD_DEBUG_LEVEL2, "partitions[%d] = "
> --
> 1.6.4
>
>
next prev parent reply other threads:[~2010-10-13 3:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 10:18 [PATCH v4 0/5] refactor spi_mpc8xxx.c and add eSPI controller support Mingkai Hu
2010-10-12 10:18 ` [PATCH v4 1/5] spi/mpc8xxx: rename spi_mpc8xxx.c to spi_fsl_spi.c Mingkai Hu
2010-10-12 10:18 ` [PATCH v4 2/5] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Mingkai Hu
2010-10-12 10:18 ` [PATCH v4 3/5] eSPI: add eSPI controller support Mingkai Hu
2010-10-12 10:18 ` [PATCH v4 4/5] powerpc/of: add eSPI controller dts bindings and DTS modification Mingkai Hu
2010-10-12 10:18 ` [PATCH v4 5/5] mtd: m25p80: add support to parse the partitions by OF node Mingkai Hu
2010-10-13 3:44 ` Grant Likely [this message]
2010-10-16 19:17 ` Artem Bityutskiy
2010-10-17 1:05 ` Grant Likely
2010-10-17 7:44 ` Artem Bityutskiy
2010-10-22 6:01 ` Kumar Gala
2010-10-22 7:39 ` Grant Likely
2010-10-13 3:41 ` [PATCH v4 4/5] powerpc/of: add eSPI controller dts bindings and DTS modification Grant Likely
2010-10-13 3:41 ` [PATCH v4 3/5] eSPI: add eSPI controller support Grant Likely
2010-10-13 3:41 ` [PATCH v4 2/5] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Grant Likely
2010-10-13 3:40 ` [PATCH v4 1/5] spi/mpc8xxx: rename spi_mpc8xxx.c to spi_fsl_spi.c Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013034437.GE7254@angua.secretlab.ca \
--to=grant.likely@secretlab$(echo .)ca \
--cc=Mingkai.hu@freescale$(echo .)com \
--cc=david-b@pacbell$(echo .)net \
--cc=dwmw2@infradead$(echo .)org \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=spi-devel-general@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox