From: Jeremy Kerr <jk@ozlabs•org>
To: cbe-oss-dev@lists•ozlabs.org
Cc: Jiri Kosina <trivial@kernel•org>,
kvm@vger•kernel.org, Arnd Bergmann <arnd@arndb•de>,
Marcelo Tosatti <mtosatti@redhat•com>,
Alexander Graf <agraf@suse•de>,
kvm-ppc@vger•kernel.org, linux-kernel@vger•kernel.org,
Paul Mackerras <paulus@samba•org>, Avi Kivity <avi@redhat•com>,
Joe Perches <joe@perches•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [Cbe-oss-dev] [PATCH 03/49] arch/powerpc: Use vzalloc
Date: Fri, 5 Nov 2010 09:08:49 -0400 [thread overview]
Message-ID: <201011050908.50190.jk@ozlabs.org> (raw)
In-Reply-To: <5da00d7f95b5c7a96fbfa8420f5e3a8ef33e01e6.1288925424.git.joe@perches.com>
Hi Joe,
> diff --git a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
> b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c index a101abf..3b894f5
> 100644
> --- a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
> +++ b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
> @@ -36,10 +36,9 @@ static int spu_alloc_lscsa_std(struct spu_state *csa)
> struct spu_lscsa *lscsa;
> unsigned char *p;
>
> - lscsa = vmalloc(sizeof(struct spu_lscsa));
> + lscsa = vzalloc(sizeof(struct spu_lscsa));
> if (!lscsa)
> return -ENOMEM;
> - memset(lscsa, 0, sizeof(struct spu_lscsa));
> csa->lscsa = lscsa;
>
> /* Set LS pages reserved to allow for user-space mapping. */
For the spufs bit:
Acked-By: Jeremy Kerr <jk@ozlabs•org>
Cheers,
Jeremy
prev parent reply other threads:[~2010-11-05 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.1011031108260.11625@router.home>
2010-11-05 3:07 ` [PATCH 00/49] Use vzalloc not vmalloc/kmemset Joe Perches
2010-11-05 3:07 ` [PATCH 03/49] arch/powerpc: Use vzalloc Joe Perches
2010-11-05 13:08 ` Jeremy Kerr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011050908.50190.jk@ozlabs.org \
--to=jk@ozlabs$(echo .)org \
--cc=agraf@suse$(echo .)de \
--cc=arnd@arndb$(echo .)de \
--cc=avi@redhat$(echo .)com \
--cc=cbe-oss-dev@lists$(echo .)ozlabs.org \
--cc=joe@perches$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mtosatti@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=trivial@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox