From: Greg KH <greg@kroah•com>
To: tmarri@apm•com
Cc: linux-usb@vger•kernel.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH V6 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
Date: Fri, 10 Dec 2010 14:44:02 -0800 [thread overview]
Message-ID: <20101210224402.GA8943@kroah.com> (raw)
In-Reply-To: <1291854539-23879-1-git-send-email-tmarri@apm.com>
On Wed, Dec 08, 2010 at 04:28:59PM -0800, tmarri@apm•com wrote:
> From: Tirumala Marri <tmarri@apm•com>
>
> v6:
> 1. Replaced register definitions and bit fields with macros.
> 2. Replace printks with dev_dbg or dev_err functions.
> 3. Cleanup some assignments.
> 4. Remove chip specific selections in Kconfig file.
There are still a lot of checkpatch errors and warnings in these
patches. Patch 1-8 has:
total: 64 errors, 126 warnings, 13905 lines checked
Care to fix all of these up in your next submission? I can't take these
as-is, sorry.
And, if you haven't run checkpatch.pl before, odds are you haven't run
'sparse'. Please run that as well and resolve the issues it finds.
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-10 22:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 0:28 [PATCH V6 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver tmarri
2010-12-09 6:47 ` Greg KH
2010-12-09 16:45 ` Tirumala Marri
2010-12-09 16:47 ` Tirumala Marri
2010-12-10 4:52 ` Alexander Gordeev
2010-12-10 6:21 ` Tirumala Marri
2010-12-10 22:44 ` Greg KH [this message]
2010-12-11 17:53 ` Tirumala Marri
2010-12-13 15:48 ` Neil Jones
2010-12-15 10:17 ` Neil Jones
2010-12-15 22:50 ` Tirumala Marri
-- strict thread matches above, loose matches on Subject: below --
2010-12-09 0:16 tmarri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210224402.GA8943@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=tmarri@apm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox