From: torbenh <torbenh@gmx•de>
To: Greg KH <gregkh@suse•de>
Cc: xen-devel@lists•xensource.com,
"Kees Cook" <kees.cook@canonical•com>,
linux-fbdev@vger•kernel.org, "James Hogan" <james@albanarts•com>,
"David Airlie" <airlied@linux•ie>,
"Jesse Barnes" <jbarnes@virtuousgeek•org>,
"James Morris" <jmorris@namei•org>,
"Paul Mackerras" <paulus@samba•org>,
linux-parisc@vger•kernel.org, "Magnus Damm" <damm@opensource•se>,
"Jiri Slaby" <jslaby@suse•cz>,
"Dan Williams" <dan.j.williams@intel•com>,
devel@driverdev•osuosl.org, "Guy Martin" <gmsoft@tuxicoman•be>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas•com>,
"Jeremy Fitzhardinge" <jeremy.fitzhardinge@citrix•com>,
"Russell King" <linux@arm•linux.org.uk>,
"Thomas Gleixner" <tglx@tglx•de>,
"Wu Zhangjin" <wuzhangjin@gmail•com>,
"Florian Tobias Schandinat" <FlorianSchandinat@gmx•de>,
"Lionel Debroux" <lionel_debroux@yahoo•fr>,
"Helge Deller" <deller@gmx•de>,
"Kay Sievers" <kay.sievers@vrfy•org>,
"James E.J. Bottomley" <jejb@parisc-linux•org>,
"Kevin Hilman" <khilman@deeprootsystems•com>,
"Tony Lindgren" <tony@atomide•com>,
cbe-oss-dev@lists•ozlabs.org, "Ben Skeggs" <bskeggs@redhat•com>,
"Ingo Molnar" <mingo@elte•hu>,
"Daniel Vetter" <daniel.vetter@ffwll•ch>,
"Dave Airlie" <airlied@redhat•com>,
"David Brown" <davidb@codeaurora•org>,
"Francisco Jerez" <currojerez@riseup•net>,
virtualization@lists•linux-foundation.org,
"Namhyung Kim" <namhyung@gmail•com>,
"Marcin Slusarz" <marcin.slusarz@gmail•com>,
"Alberto Panizzo" <maramaopercheseimorto@gmail•com>,
"Rusty Russell" <rusty@rustcorp•com.au>,
"Ondrej Zary" <linux@rainbow-software•org>,
"Denys Vlasenko" <vda.linux@googlemail•com>,
"Antonino Daplas" <adaplas@gmail•com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle•com>,
"Abhijeet Dharmapurikar" <adharmap@codeaurora•org>,
"Andres Salomon" <dilinger@queued•net>,
"Werner Fink" <werner@suse•de>,
"Phil Edworthy" <phil.edworthy@renesas•com>,
linux-geode@lists•infradead.org,
"Alex Deucher" <alexdeucher@gmail•com>,
"Jerome Glisse" <jglisse@redhat•com>,
"Lars-Peter Clausen" <lars@metafoo•de>,
"Alexey Dobriyan" <adobriyan@gmail•com>,
"Daniel Mack" <daniel@caiaq•de>,
"Nicolas Pitre" <nicolas.pitre@canonical•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
linux-omap@vger•kernel.org,
"Ondrej Zajicek" <santiago@crfreenet•org>,
linux-arm-kernel@lists•infradead.org,
"Liam Girdwood" <lrg@slimlogic•co.uk>,
"Daniel Walker" <dwalker@codeaurora•org>,
"Linus Walleij" <linus.walleij@stericsson•com>,
"Caglar Akyuz" <caglar@bilkon-kontrol•com.tr>,
"Geoff Levand" <geoff@infradead•org>,
"Jiri Kosina" <jkosina@suse•cz>,
dri-devel@lists•freedesktop.org,
"Mark Brown" <broonie@opensource•wolfsonmicro.com>,
linux-kernel@vger•kernel.org,
"Ralf Baechle" <ralf@linux-mips•org>,
"Guennadi Liakhovetski" <g.liakhovetski@gmx•de>,
"Kyle McMartin" <kyle@mcmartin•ca>,
"Jean Delvare" <khali@linux-fr•org>,
"Paul Mundt" <lethal@linux-sh•org>,
"Arnd Bergmann" <arnd@arndb•de>, "Takashi Iwai" <tiwai@suse•de>,
"Jason Wessel" <jason.wessel@windriver•com>,
"Tejun Heo" <tj@kernel•org>, "Julia Lawall" <julia@diku•dk>,
"Andrew Morton" <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>,
"Marcin Kościelnicki" <koriakin@0x04•net>
Subject: Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()
Date: Thu, 20 Jan 2011 17:55:02 +0100 [thread overview]
Message-ID: <20110120165502.GA10832@siel.b> (raw)
In-Reply-To: <20110120163448.GA30588@suse.de>
On Thu, Jan 20, 2011 at 08:34:48AM -0800, Greg KH wrote:
> On Thu, Jan 20, 2011 at 04:58:13PM +0100, Torben Hohn wrote:
> > the -rt patches change the console_semaphore to console_mutex.
> > so a quite large chunk of the patches changes all
> > acquire/release_console_sem() to acquire/release_console_mutex()
>
> Why not just change the functionality of the existing function to be a
> mutex in the rt patches, instead of having to rename it everywhere?
i hope that Thomas already did this in his upcoming -rt series.
>
> > this commit makes things use more neutral function names
> > which dont make implications about the underlying lock.
> >
> > the only real change is the return value of console_trylock
> > which is inverted from try_acquire_console_sem()
> >
> > Signed-off-by: Torben Hohn <torbenh@gmx•de>
> > CC: Thomas Gleixner <tglx@tglx•de>
>
> I don't mind this rename, but is it really going to help anything out?
> What's the odds of the -rt portion of this patch ever making it to
> mainline?
the -rt portion only changes the semaphore to a mutex.
since the console_sem is used with mutex semantics, i dont see any
reason, not to merge that portion too.
i am just trying to shrink the -rt patch to make it more maintanable :)
>
> thanks,
>
> greg k-h
--
torben Hohn
next prev parent reply other threads:[~2011-01-20 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 15:58 [PATCH] change acquire/release_console_sem() to console_lock/unlock() Torben Hohn
2011-01-20 16:34 ` Greg KH
2011-01-20 16:55 ` torbenh [this message]
2011-01-20 20:35 ` Andrew Morton
2011-01-21 8:10 ` Geert Uytterhoeven
2011-01-21 8:23 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120165502.GA10832@siel.b \
--to=torbenh@gmx$(echo .)de \
--cc=FlorianSchandinat@gmx$(echo .)de \
--cc=adaplas@gmail$(echo .)com \
--cc=adharmap@codeaurora$(echo .)org \
--cc=adobriyan@gmail$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=airlied@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexdeucher@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=bskeggs@redhat$(echo .)com \
--cc=caglar@bilkon-kontrol$(echo .)com.tr \
--cc=cbe-oss-dev@lists$(echo .)ozlabs.org \
--cc=currojerez@riseup$(echo .)net \
--cc=damm@opensource$(echo .)se \
--cc=dan.j.williams@intel$(echo .)com \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=daniel@caiaq$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=davidb@codeaurora$(echo .)org \
--cc=deller@gmx$(echo .)de \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=dilinger@queued$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dwalker@codeaurora$(echo .)org \
--cc=g.liakhovetski@gmx$(echo .)de \
--cc=geoff@infradead$(echo .)org \
--cc=gmsoft@tuxicoman$(echo .)be \
--cc=gregkh@suse$(echo .)de \
--cc=james@albanarts$(echo .)com \
--cc=jason.wessel@windriver$(echo .)com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=jejb@parisc-linux$(echo .)org \
--cc=jeremy.fitzhardinge@citrix$(echo .)com \
--cc=jglisse@redhat$(echo .)com \
--cc=jkosina@suse$(echo .)cz \
--cc=jmorris@namei$(echo .)org \
--cc=jslaby@suse$(echo .)cz \
--cc=julia@diku$(echo .)dk \
--cc=kay.sievers@vrfy$(echo .)org \
--cc=kees.cook@canonical$(echo .)com \
--cc=khali@linux-fr$(echo .)org \
--cc=khilman@deeprootsystems$(echo .)com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=koriakin@0x04$(echo .)net \
--cc=kuninori.morimoto.gx@renesas$(echo .)com \
--cc=kyle@mcmartin$(echo .)ca \
--cc=lars@metafoo$(echo .)de \
--cc=lethal@linux-sh$(echo .)org \
--cc=linus.walleij@stericsson$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-geode@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linux@rainbow-software$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lionel_debroux@yahoo$(echo .)fr \
--cc=lrg@slimlogic$(echo .)co.uk \
--cc=maramaopercheseimorto@gmail$(echo .)com \
--cc=marcin.slusarz@gmail$(echo .)com \
--cc=mingo@elte$(echo .)hu \
--cc=namhyung@gmail$(echo .)com \
--cc=nicolas.pitre@canonical$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=phil.edworthy@renesas$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=santiago@crfreenet$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tglx@tglx$(echo .)de \
--cc=tiwai@suse$(echo .)de \
--cc=tj@kernel$(echo .)org \
--cc=tony@atomide$(echo .)com \
--cc=vda.linux@googlemail$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=werner@suse$(echo .)de \
--cc=wuzhangjin@gmail$(echo .)com \
--cc=xen-devel@lists$(echo .)xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox