From: "Ira W. Snyder" <iws@ovro•caltech.edu>
To: Felix Radensky <felix@embedded-sol•com>
Cc: "linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH 0/8] fsldma: lockup fixes
Date: Wed, 2 Mar 2011 08:42:47 -0800 [thread overview]
Message-ID: <20110302164247.GC18826@ovro.caltech.edu> (raw)
In-Reply-To: <4D6DDA85.8070204@embedded-sol.com>
On Wed, Mar 02, 2011 at 07:49:57AM +0200, Felix Radensky wrote:
> Hi Ira,
>
> On 03/01/2011 09:52 PM, Ira W. Snyder wrote:
> > On Tue, Mar 01, 2011 at 08:55:15AM -0800, Ira W. Snyder wrote:
> >
> > [ big snip ]
> >
> >
> > I'd still like the bisect if you have a chance. I've re-reviewed the
> > patch series, and found the places that change register writes to the
> > controller.
> >
> > The patch below changes the register operations back to the original
> > order. It doesn't make any sense why this would be required, but it is
> > worth a quick try.
> >
> > I've added an "XXX" mark where you can comment out a single line if this
> > patch fails. It is highly unlikely to make any difference, but I'm
> > really having a hard time understanding what is wrong.
> >
> >
> This patch fixes the problem. See below
>
Excellent! I know what is happening now. The 85xx controller doesn't
clear the "channel start" bit at the end of a transfer. Sure enough,
buried near the end of the chapter, the datasheet implies this in a
table very far away from the register definitions. The 83xx datasheet
explicitly states that it clears this bit automatically.
I'll post an updated patch series later today. Thank you so much for
being patient and trying out all of these patches.
Ira
next prev parent reply other threads:[~2011-03-02 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 18:47 [PATCH 0/8] fsldma: lockup fixes Felix Radensky
2011-02-28 19:53 ` Ira W. Snyder
2011-02-28 20:15 ` Felix Radensky
2011-02-28 21:11 ` Ira W. Snyder
2011-02-28 21:27 ` Felix Radensky
2011-03-01 0:21 ` Ira W. Snyder
2011-03-01 5:46 ` Felix Radensky
2011-03-01 5:52 ` Felix Radensky
2011-03-01 16:55 ` Ira W. Snyder
2011-03-01 19:52 ` Ira W. Snyder
2011-03-02 5:49 ` Felix Radensky
2011-03-02 16:42 ` Ira W. Snyder [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-28 11:36 Felix Radensky
2011-02-28 17:16 ` Ira W. Snyder
2011-02-26 0:23 Ira W. Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302164247.GC18826@ovro.caltech.edu \
--to=iws@ovro$(echo .)caltech.edu \
--cc=felix@embedded-sol$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox