public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Arnd Bergmann <arnd@arndb•de>
To: Richard Cochran <richardcochran@gmail•com>
Cc: Thomas Gleixner <tglx@linutronix•de>,
	Rodolfo Giometti <giometti@linux•it>,
	Peter Zijlstra <peterz@infradead•org>,
	linux-api@vger•kernel.org, devicetree-discuss@lists•ozlabs.org,
	linux-kernel@vger•kernel.org,
	Russell King <linux@arm•linux.org.uk>,
	Paul Mackerras <paulus@samba•org>,
	John Stultz <john.stultz@linaro•org>,
	Alan Cox <alan@lxorguk•ukuu.org.uk>,
	netdev@vger•kernel.org, Mike Frysinger <vapier@gentoo•org>,
	Christoph Lameter <cl@linux•com>,
	linuxppc-dev@lists•ozlabs.org, David Miller <davem@davemloft•net>,
	linux-arm-kernel@lists•infradead.org,
	Krzysztof Halasa <khc@pm•waw.pl>
Subject: Re: [PATCH V14 3/4] ptp: Added a clock driver for the IXP46x.
Date: Mon, 18 Apr 2011 10:26:38 +0200	[thread overview]
Message-ID: <201104181026.39107.arnd@arndb.de> (raw)
In-Reply-To: <201104181021.01279.arnd@arndb.de>

On Monday 18 April 2011, Arnd Bergmann wrote:
> On Monday 18 April 2011, Richard Cochran wrote:
> > On Mon, Apr 18, 2011 at 08:56:03AM +0200, Arnd Bergmann wrote:
> > > On Monday 18 April 2011, Richard Cochran wrote:
> > > > +
> > > > +       lo = __raw_readl(&regs->channel[ch].src_uuid_lo);
> > > > +       hi = __raw_readl(&regs->channel[ch].src_uuid_hi);
> > > > +
> > > 
> > > I guess you should use readl(), not __raw_readl() here. The __raw_* functions
> > > are not meant for device drivers.
> > 
> > Krzysztof had a different opinion about this.
> > 
> >     https://lkml.org/lkml/2011/1/8/67
> > 
> > Anyway, it is his driver, and I just followed what he does elsewhere
> > in the driver. It make sense to me to keep the driver consistent.
> > Maybe we should make the change throughout?
> 
> It would certainly be useful to fix it up. I now realized that this driver
> supports both big-endian and little-endian configurations, so just using
> readl() is certainly broken.
> There should probably be an ixp specific version of the safe I/O accessors
> to deal with it on all on-chip peripherals in a safe way.

Anyway, not your problem then, just leave it like it is.

Acked-by: Arnd Bergmann <arnd@arndb•de>

next prev parent reply	other threads:[~2011-04-18  8:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18  6:27 [PATCH V14 0/4] ptp: IEEE 1588 hardware clock support Richard Cochran
2011-04-18  6:28 ` [PATCH V14 1/4] ptp: Added a brand new class driver for ptp clocks Richard Cochran
2011-04-18  6:54   ` Arnd Bergmann
2011-04-18  6:29 ` [PATCH V14 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx Richard Cochran
2011-04-18  6:29 ` [PATCH V14 3/4] ptp: Added a clock driver for the IXP46x Richard Cochran
2011-04-18  6:56   ` Arnd Bergmann
2011-04-18  8:06     ` Richard Cochran
2011-04-18  8:16       ` Richard Cochran
2011-04-18  8:21       ` Arnd Bergmann
2011-04-18  8:26         ` Arnd Bergmann [this message]
2011-04-18 20:53   ` Ben Hutchings
2011-04-18  6:30 ` [PATCH V14 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER Richard Cochran
2011-04-18 20:57   ` Ben Hutchings
2011-04-22  9:21     ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104181026.39107.arnd@arndb.de \
    --to=arnd@arndb$(echo .)de \
    --cc=alan@lxorguk$(echo .)ukuu.org.uk \
    --cc=cl@linux$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=devicetree-discuss@lists$(echo .)ozlabs.org \
    --cc=giometti@linux$(echo .)it \
    --cc=john.stultz@linaro$(echo .)org \
    --cc=khc@pm$(echo .)waw.pl \
    --cc=linux-api@vger$(echo .)kernel.org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux@arm$(echo .)linux.org.uk \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=paulus@samba$(echo .)org \
    --cc=peterz@infradead$(echo .)org \
    --cc=richardcochran@gmail$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=vapier@gentoo$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox