From: Richard Weinberger <richard@nod•at>
To: Eric Paris <eparis@redhat•com>
Cc: linux-mips@linux-mips•org, linux-ia64@vger•kernel.org,
linux-sh@vger•kernel.org, heiko.carstens@de•ibm.com,
oleg@redhat•com, paulus@samba•org, hpa@zytor•com,
sparclinux@vger•kernel.org, linux-s390@vger•kernel.org,
x86@kernel•org, mingo@redhat•com, fenghua.yu@intel•com,
user-mode-linux-devel@lists•sourceforge.net,
microblaze-uclinux@itee•uq.edu.au, jdike@addtoit•com,
viro@zeniv•linux.org.uk, tglx@linutronix•de, monstr@monstr•eu,
tony.luck@intel•com, linux-kernel@vger•kernel.org,
ralf@linux-mips•org, lethal@linux-sh•org, schwidefsky@de•ibm.com,
linux390@de•ibm.com, akpm@linux-foundation•org,
linuxppc-dev@lists•ozlabs.org, davem@davemloft•net
Subject: Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h
Date: Sun, 5 Jun 2011 00:36:44 +0200 [thread overview]
Message-ID: <201106050036.44852.richard@nod.at> (raw)
In-Reply-To: <20110603220451.23134.47368.stgit@paris.rdu.redhat.com>
Am Samstag 04 Juni 2011, 00:04:51 schrieb Eric Paris:
> The audit system previously expected arches calling to audit_syscall_exit
> to supply as arguments if the syscall was a success and what the return
> code was. Audit also provides a helper AUDITSC_RESULT which was supposed
> to simplify things by converting from negative retcodes to an audit
> internal magic value stating success or failure. This helper was wrong
> and could indicate that a valid pointer returned to userspace was a failed
> syscall. The fix is to fix the layering foolishness. We now pass
> audit_syscall_exit a struct pt_reg and it in turns calls back into arch
> code to collect the return value and to determine if the syscall was a
> success or failure. We also define a generic is_syscall_success() macro
> which determines success/failure based on if the value is < -MAX_ERRNO.
> This works for arches like x86 which do not use a separate mechanism to
> indicate syscall failure.
>
> In arch/sh/kernel/ptrace_64.c I see that we were using regs[9] in the old
> audit code as the return value. But the ptrace_64.h code defined the macro
> regs_return_value() as regs[3]. I have no idea which one is correct, but
> this patch now uses the regs_return_value() function, so it now uses
> regs[3].
>
> We make both the is_syscall_success() and regs_return_value() static
> inlines instead of macros. The reason is because the audit function must
> take a void* for the regs. (uml calls theirs struct uml_pt_regs instead
> of just struct pt_regs so audit_syscall_exit can't take a struct pt_regs).
> Since the audit function takes a void* we need to use static inlines to
> cast it back to the arch correct structure to dereference it.
>
> The other major change is that on some arches, like ia64, we change
> regs_return_value() to give us the negative value on syscall failure. The
> only other user of this macro, kretprobe_example.c, won't notice and it
> makes the value signed consistently for the audit functions across all
> archs.
>
> Signed-off-by: Eric Paris <eparis@redhat•com>
> Acked-by: Acked-by: H. Peter Anvin <hpa@zytor•com> [for x86 portion]
The UML part is now fine for me. :-)
Acked-by: Richard Weinberger <richard@nod•at>
Thanks,
//richard
next prev parent reply other threads:[~2011-06-04 22:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 22:04 [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h Eric Paris
2011-06-03 22:52 ` Tony Luck
2011-06-04 22:36 ` Richard Weinberger [this message]
2011-06-06 20:17 ` David Miller
2011-06-07 17:19 ` Oleg Nesterov
2011-06-07 18:53 ` Eric Paris
2011-06-08 16:36 ` Oleg Nesterov
2011-06-08 18:13 ` Eric Paris
2011-06-08 18:37 ` Oleg Nesterov
2011-06-08 19:19 ` Oleg Nesterov
2011-06-08 14:04 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106050036.44852.richard@nod.at \
--to=richard@nod$(echo .)at \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eparis@redhat$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=microblaze-uclinux@itee$(echo .)uq.edu.au \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=oleg@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox