From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@lists•ozlabs.org
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail•com>,
davej@redhat•com, paulus@samba•org, cpufreq@vger•kernel.org
Subject: Re: [PATCH] Add cpufreq driver for Momentum Maple boards
Date: Fri, 17 Jun 2011 11:17:14 +0200 [thread overview]
Message-ID: <201106171117.14794.arnd@arndb.de> (raw)
In-Reply-To: <1308300556-4463-1-git-send-email-dbaryshkov@gmail.com>
On Friday 17 June 2011 10:49:16 Dmitry Eremin-Solenikov wrote:
> Add simple cpufreq driver for Maple-based boards (ppc970fx evaluation
> kit and others). Driver is based on a cpufreq driver for 64-bit powermac
> boxes with all pmac-dependant features removed and simple cleanup
> applied.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail•com>
> ---
> arch/powerpc/kernel/misc_64.S | 4 +-
> arch/powerpc/platforms/Kconfig | 8 +
> arch/powerpc/platforms/maple/Makefile | 1 +
> arch/powerpc/platforms/maple/cpufreq.c | 317 ++++++++++++++++++++++++++++++++
> 4 files changed, 328 insertions(+), 2 deletions(-)
> create mode 100644 arch/powerpc/platforms/maple/cpufreq.c
>
I think new cpufreq drivers should live in drivers/cpufreq, not in arch/. We've
started moving other drivers away from arch/x86 and arch/arm already.
The code itself looks good.
Arnd
next prev parent reply other threads:[~2011-06-17 9:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 10:28 [PATCH] Add cpufreq driver for Momentum Maple boards Dmitry Eremin-Solenikov
2011-05-30 11:57 ` Dmitry Eremin-Solenikov
2011-06-04 9:00 ` Dmitry Eremin-Solenikov
2011-06-04 10:29 ` Benjamin Herrenschmidt
2011-06-04 10:39 ` Dmitry Eremin-Solenikov
2011-06-17 4:14 ` Benjamin Herrenschmidt
2011-06-17 8:49 ` Dmitry Eremin-Solenikov
2011-06-17 9:17 ` Arnd Bergmann [this message]
2011-06-17 11:12 ` Dmitry Eremin-Solenikov
2011-06-17 11:52 ` Arnd Bergmann
2011-06-17 20:07 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106171117.14794.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=cpufreq@vger$(echo .)kernel.org \
--cc=davej@redhat$(echo .)com \
--cc=dbaryshkov@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox