Subject: Re: [PATCH 6/9] arch/powerpc/platforms/pseries/iommu.c: add missing kfree

From: Nishanth Aravamudan <[email-masked]>
Date: Mon, 8 Aug 2011 10:47:10 -0700

On 08.08.2011 [13:18:00 +0200], Julia Lawall wrote:
> From: Julia Lawall <[email-masked]>
> 
> At this point, window has not been stored anywhere, so it has to be freed
> before leaving the function.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @exists@
> local idexpression x;
> statement S,S1;
> expression E;
> identifier fl;
> expression *ptr != NULL;
> @@
> 
> x = \(kmalloc\|kzalloc\|kcalloc\)(...);
> ...
> if (x == NULL) S
> <... when != x
>      when != if (...) { <+...kfree(x)...+> }
>      when any
>      when != true x == NULL
> x->fl
> ...>
> (
> if (x == NULL) S1
> |
> if (...) { ... when != x
>                when forall
> (
>  return \(0\|<+...x...+>\|ptr\);
> |
> * return ...;
> )
> }
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <[email-masked]>

Acked-by: Nishanth Aravamudan <[email-masked]>

Thanks,
Nish

-- 
Nishanth Aravamudan <[email-masked]>
IBM Linux Technology Center