From: Olof Johansson <olof@lixom•net>
To: tmarri@apm•com
Cc: greg@kroah•com, linux-usb@vger•kernel.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
Date: Fri, 21 Oct 2011 10:33:02 -0700 [thread overview]
Message-ID: <20111021173302.GB27652@quad.lixom.net> (raw)
In-Reply-To: <1318630114-14064-1-git-send-email-tmarri@apm.com>
On Fri, Oct 14, 2011 at 03:08:34PM -0700, tmarri@apm•com wrote:
> From: Tirumala Marri <tmarri@apm•com>
Overall this driver seems to be based on the IP vendor driver? It
looks like a completely flexible driver that implements all possible
combinations of everything.
And as a result, it's huge, and it's got a lot of extra code in there that I'm
willing to bet that you have never even executed on your platform.
Please, pare it down to the portions that you have used, and know works
and can support. If others need the extra functionality in the future,
they can and will expand and bring in what is needed.
Compare this to the dwc3 driver, which is much much cleaner.
Overall other comments:
* Register definitions are crazy long. It means you have to do lots of line
wraps to keep the 80-character limit, which makes it hard to read the code.
* The header files seem to have been autogenerated and have unnneeded
shift/mask operations.
* It doesn't build on non-powerpc platforms since it uses out_{b,l}e accessors.
-Olof
next prev parent reply other threads:[~2011-10-21 17:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 22:08 [PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver tmarri
2011-10-21 3:48 ` Pratyush Anand
2011-10-25 22:45 ` Tirumala Marri
2011-10-21 17:33 ` Olof Johansson [this message]
2011-10-22 20:30 ` Olof Johansson
2011-10-27 5:07 ` Pratyush Anand
2011-10-25 21:54 ` Tirumala Marri
2011-10-26 12:04 ` Olof Johansson
2011-10-26 16:06 ` Tirumala Marri
2011-10-27 3:52 ` Geoff Levand
2011-10-26 17:17 ` Tirumala Marri
2011-10-27 4:51 ` Greg KH
2011-10-28 0:25 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021173302.GB27652@quad.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=greg@kroah$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=tmarri@apm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox