From: Tony Breeds <tony@bakeyournoodle•com>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: LinuxPPC-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 5/6] powerpc/boot: Add mfdcrx
Date: Thu, 1 Dec 2011 10:30:27 +1100 [thread overview]
Message-ID: <20111130233027.GC15560@thor.bakeyournoodle.com> (raw)
In-Reply-To: <F91E9007-5DA5-4E3A-993E-EA680DE08D79@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
On Wed, Nov 30, 2011 at 02:09:20PM +0100, Segher Boessenkool wrote:
> >+#define mfdcrx(rn) \
> >+ ({ \
> >+ unsigned long rval; \
> >+ asm volatile("mfdcrx %0,%1" : "=r"(rval) : "g"(rn)); \
> >+ rval; \
> >+ })
>
> "g" is never correct on PowerPC, you want "r" here. You can write
> this as a static inline btw, you only need the #define stuff when
> there is an "i" constraint involved.
Okay I'll change it to "i", mostly I used a #define to match the style
of m[tf]dcr. To be honnest I didn't know about the issue with "i"
constraints and static inlines.
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-30 23:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 5:23 Add support for the currituck 476 platform from IBM Tony Breeds
2011-11-30 5:23 ` [PATCH 1/6] 44x/pci: Continue pci setup even if there is no sdr-base in the device-tree Tony Breeds
2011-11-30 5:46 ` Benjamin Herrenschmidt
2011-12-01 1:11 ` Tony Breeds
2011-11-30 5:23 ` [PATCH 2/6] 44x/pci: Setup the dma_window properties for each pci_controller Tony Breeds
2011-11-30 5:23 ` [PATCH 3/6] 44x: Removing dead CONFIG_PPC47x Tony Breeds
2011-11-30 11:43 ` Josh Boyer
2011-11-30 20:20 ` Benjamin Herrenschmidt
2011-11-30 5:23 ` [PATCH 4/6] powerpc/boot: Add extended precision shifts to the boot wrapper Tony Breeds
2011-11-30 5:48 ` Benjamin Herrenschmidt
2011-11-30 11:45 ` Josh Boyer
2011-11-30 20:21 ` Benjamin Herrenschmidt
2011-11-30 20:28 ` Scott Wood
2011-11-30 23:25 ` Tony Breeds
2011-11-30 5:23 ` [PATCH 5/6] powerpc/boot: Add mfdcrx Tony Breeds
2011-11-30 13:09 ` Segher Boessenkool
2011-11-30 18:10 ` David Laight
2011-12-01 22:55 ` Segher Boessenkool
2011-11-30 23:30 ` Tony Breeds [this message]
2011-11-30 23:35 ` Tony Breeds
2011-11-30 5:24 ` [PATCH 6/6] 44x/currituck: Add support for the new IBM currituck platform Tony Breeds
2011-11-30 6:20 ` Benjamin Herrenschmidt
2011-11-30 6:31 ` David Gibson
2011-12-01 4:05 ` Tony Breeds
2011-12-01 4:29 ` Tony Breeds
2011-11-30 13:23 ` Kumar Gala
2011-12-01 4:16 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130233027.GC15560@thor.bakeyournoodle.com \
--to=tony@bakeyournoodle$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox