From: Greg KH <gregkh@linuxfoundation•org>
To: Sergei Shtylyov <sshtylyov@mvista•com>
Cc: linux-usb@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
Shengzhou Liu <Shengzhou.Liu@freescale•com>
Subject: Re: [PATCH v2] powerpc/usb: fix issue of CPU halt when missing USB PHY clock
Date: Thu, 2 Feb 2012 11:14:12 -0800 [thread overview]
Message-ID: <20120202191412.GB3027@kroah.com> (raw)
In-Reply-To: <4F2A7604.9060102@mvista.com>
On Thu, Feb 02, 2012 at 03:39:48PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 02-02-2012 7:23, Shengzhou Liu wrote:
>
> >when missing USB PHY clock, kernel booting up will halt during USB
> >initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid
> >CPU hang in this case.
>
> >Signed-off-by: Shengzhou Liu<Shengzhou.Liu@freescale•com>
> [...]
>
> >diff --git a/drivers/usb/host/ehci-fsl.h b/drivers/usb/host/ehci-fsl.h
> >index 4918062..dd3dc47 100644
> >--- a/drivers/usb/host/ehci-fsl.h
> >+++ b/drivers/usb/host/ehci-fsl.h
> >@@ -45,5 +45,6 @@
> > #define FSL_SOC_USB_PRICTRL 0x40c /* NOTE: big-endian */
> > #define FSL_SOC_USB_SICTRL 0x410 /* NOTE: big-endian */
> > #define FSL_SOC_USB_CTRL 0x500 /* NOTE: big-endian */
> >+#define CTRL_PHY_CLK_VALID (1 << 17)
>
> Indent the macro value with tabs please.
I fixed this by hand.
prev parent reply other threads:[~2012-02-02 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 3:23 [PATCH v2] powerpc/usb: fix issue of CPU halt when missing USB PHY clock Shengzhou Liu
2012-02-02 11:39 ` Sergei Shtylyov
2012-02-02 19:14 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202191412.GB3027@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=Shengzhou.Liu@freescale$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=sshtylyov@mvista$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox