Subject: Re: [PATCH 14/21] Introduce EEH device

From: Gavin Shan <[email-masked]>
Date: Tue, 28 Feb 2012 09:13:54 +0800

> Hi Gavin,
> 
> On Fri, 24 Feb 2012 17:38:11 +0800 Gavin Shan <[email-masked]> wrote:
> >
> > +#define EEH_DEV_TO_OF_NODE(edev)	(edev->dn)
> > +#define EEH_DEV_TO_PCI_DEV(edev)	(edev->pdev)
> > +#define OF_NODE_TO_EEH_DEV(dn)		((struct eeh_dev *)(dn->edev))
> > +#define PCI_DEV_TO_EEH_DEV(pdev)	((struct eeh_dev *)(pdev->dev.archdata.edev))
> 
> You need to put parentheses around the use of macro arguments ... or,
> even better, make these into "static inline" accessor functions (with
> lower case names).
> 

Thanks for your comments, Stephen. I'd like to make "static inline"
functions for them in next revision ;-)

Thanks,
Gavin

> -- 
> Cheers,
> Stephen Rothwell                    [email-masked]
> http://www.canb.auug.org.au/~sfr/