Subject: Re: [PATCH 20/21] Introduce struct eeh_stats for EEH

From: Gavin Shan <[email-masked]>
Date: Tue, 28 Feb 2012 09:22:55 +0800

>  
> > +/*
> > + * The struct is used to maintain the EEH global statistic
> > + * information. Besides, the EEH global statistics will be
> > + * exported to user space through procfs
> > + */
> > +struct eeh_stats {
> > +	unsigned long no_device;	/* PCI device not found
> */
> > +	unsigned long no_dn;		/* OF node not found
> */
> > +	unsigned long no_cfg_addr;	/* Config address not  found
> */
> > +	unsigned long ignored_check;	/* EEH check skipped
> */
> > +	unsigned long total_mmio_ffs;	/* Total EEH checks
> */
> > +	unsigned long false_positives;	/* Unnecessary EEH checks
> */
> > +	unsigned long slot_resets;	/* PE reset
> */
> > +};
> 
> Why 'unsigned long', surely either 'unsigned int'
> or a fixed-width type.
> 

Thanks, David. Could you pls give more information on
how the fixed-width types benefits us?

Thanks,
Gavin
 
> 	David