From: Olof Johansson <olof@lixom•net>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Bjorn Helgaas <bhelgaas@google•com>,
linux-pci@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-arch@vger•kernel.org
Subject: Re: [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags
Date: Sun, 4 Mar 2012 19:54:51 -0800 [thread overview]
Message-ID: <20120305035451.GB32675@quad.lixom.net> (raw)
In-Reply-To: <1329946899.20389.9.camel@pasglop>
On Thu, Feb 23, 2012 at 08:41:39AM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2012-02-22 at 11:19 -0700, Bjorn Helgaas wrote:
> > int maple_pci_get_legacy_ide_irq(struct pci_dev *pdev, int channel)
> > diff --git a/arch/powerpc/platforms/pasemi/pci.c
> > b/arch/powerpc/platforms/pasemi/pci.c
> > index b6a0ec4..b27d886 100644
> > --- a/arch/powerpc/platforms/pasemi/pci.c
> > +++ b/arch/powerpc/platforms/pasemi/pci.c
> > @@ -231,7 +231,7 @@ void __init pas_pci_init(void)
> > pci_devs_phb_init();
> >
> > /* Use the common resource allocation mechanism */
> > - pci_probe_only = 1;
> > + pci_add_flags(PCI_PROBE_ONLY);
> > }
>
> Olof, do you remember why you used to set that on pasemi ?
Oops, going through email backlog. Sorry for the slow response.
> I would have expected it to be clear, so the kernel can re-assign things
> if needed. We really only want it set for pseries because of the
> hypervisor being a PITA :-)
Well, we did have some hypervisor work done at PA Semi too, and chances
are it's from there. But it's unlikely since I think we booted pseries
(PAPR) kernels under rHype.
I suspect we just went with it for whatever legacy reasons and didn't
revisit later -- since our firmware enumerated busses reliably there
was no reason to redo it from the kernel.
I've booted a system with pci_probe_only off here, and it seems happy
enough. I'll send you a patch.
Bjorn, that means you can drop this chunk of the patch, I suppose.
-Olof
next prev parent reply other threads:[~2012-03-05 3:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120222181556.27513.9413.stgit@bhelgaas.mtv.corp.google.com>
2012-02-22 18:19 ` [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags Bjorn Helgaas
2012-02-22 21:41 ` Benjamin Herrenschmidt
2012-02-23 18:49 ` Bjorn Helgaas
2012-03-05 3:54 ` Olof Johansson [this message]
2012-03-05 3:59 ` Olof Johansson
2012-02-22 21:41 ` Benjamin Herrenschmidt
2012-02-22 22:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305035451.GB32675@quad.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox