Subject: Re: [PATCH 3/5] powerpc: dts: klondike: Add UART nodes

From: Grant Likely <[email-masked]>
Date: Tue, 03 Apr 2012 09:57:03 -0600

On Mon,  2 Apr 2012 12:09:05 +0530, Tanmay Inamdar <[email-masked]> wrote:
> Adding UART nodes in Klondike device tree file.
> 
> Signed-off-by: Tanmay Inamdar <[email-masked]>
> ---
> :100644 100644 4ff2852... d5bf2e1... M	arch/powerpc/boot/dts/klondike.dts
>  arch/powerpc/boot/dts/klondike.dts |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/klondike.dts b/arch/powerpc/boot/dts/klondike.dts
> index 4ff2852..d5bf2e1 100644
> --- a/arch/powerpc/boot/dts/klondike.dts
> +++ b/arch/powerpc/boot/dts/klondike.dts
> @@ -222,6 +222,30 @@
>  				#size-cells = <1>;
>  				ranges;
>  				clock-frequency = <0>;
> +
> +				UART0: serial@50001000 {
> +				       device_type = "serial";
> +				       compatible = "ns16550";
> +				       reg = <0x50001000 0x00000100>;
> +				       virtual-reg = <0x50001000>;

Why do you need virtual-reg?  The kernel should handle all iomapping
properly without this.

g.