From: Tony Breeds <tony@bakeyournoodle•com>
To: Michael Neuling <mikey@neuling•org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: fix uninitialised error in numa.c
Date: Wed, 20 Jun 2012 15:38:08 +1000 [thread overview]
Message-ID: <20120620053808.GD11330@thor.bakeyournoodle.com> (raw)
In-Reply-To: <20741.1340165867@neuling.org>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Wed, Jun 20, 2012 at 02:17:47PM +1000, Michael Neuling wrote:
> chroma_defconfig currently gives me this with gcc 4.6:
> arch/powerpc/mm/numa.c:638:13: error: 'dm' may be used uninitialized in this function [-Werror=uninitialized]
>
> It's a bogus warning since of_get_drconf_memory() only writes it
> anyway.
>
> Signed-off-by: Michael Neuling <mikey@neuling•org>
> cc: stable@kernel•org
> ---
> Also affects 3.4 and 3.3 stable.
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 5ca3a15..880acde 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -637,7 +637,7 @@ static inline int __init read_usm_ranges(const u32 **usm)
> */
> static void __init parse_drconf_memory(struct device_node *memory)
> {
> - const u32 *dm, *usm;
> + const u32 *dm = NULL, *usm;
Woot bikeshed! I think that's what the uninitialized_var() macro is for.
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-20 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 4:17 [PATCH] powerpc: fix uninitialised error in numa.c Michael Neuling
2012-06-20 5:38 ` Tony Breeds [this message]
2012-06-20 5:46 ` Michael Neuling
2012-06-20 6:01 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620053808.GD11330@thor.bakeyournoodle.com \
--to=tony@bakeyournoodle$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox