From: Ram Pai <linuxram@us•ibm.com>
To: Gavin Shan <shangw@linux•vnet.ibm.com>
Cc: linux-pci@vger•kernel.org, Ram Pai <linuxram@us•ibm.com>,
linuxppc-dev@ozlabs•org, bhelgaas@google•com, yinghai@kernel•org
Subject: Re: [PATCH 05/15] pci: resource assignment based on p2p alignment
Date: Tue, 17 Jul 2012 13:57:15 +0800 [thread overview]
Message-ID: <20120717055715.GF2369@ram-ThinkPad-T61> (raw)
In-Reply-To: <20120717053648.GA18497@shangw>
On Tue, Jul 17, 2012 at 01:36:49PM +0800, Gavin Shan wrote:
> On Tue, Jul 17, 2012 at 01:23:33PM +0800, Ram Pai wrote:
> >On Tue, Jul 17, 2012 at 01:05:47PM +0800, Ram Pai wrote:
> >> On Tue, Jul 17, 2012 at 10:23:17AM +0800, Gavin Shan wrote:
> >> > The patch changes function pbus_size_io() and pbus_size_mem() to
> >> > do resource (I/O, memory and prefetchable memory) reassignment
> >> > based on the minimal alignments for the p2p bridge, which was
> >> > retrieved by function window_alignment().
> >> >
> >> > Signed-off-by: Gavin Shan <shangw@linux•vnet.ibm.com>
>
> [snip]
>
> >> > @@ -772,11 +775,11 @@ static void pbus_size_io(struct pci_bus *bus, resource_size_t min_size,
> >> > return;
> >> > }
> >> > /* Alignment of the IO window is always 4K */
> >> > - b_res->start = 4096;
> >> > + b_res->start = io_align;
> >> > b_res->end = b_res->start + size0 - 1;
> >> > b_res->flags |= IORESOURCE_STARTALIGN;
> >> > if (size1 > size0 && realloc_head) {
> >> > - add_to_list(realloc_head, bus->self, b_res, size1-size0, 4096);
> >> > + add_to_list(realloc_head, bus->self, b_res, size1-size0, io_align);
> >> > dev_printk(KERN_DEBUG, &bus->self->dev, "bridge window "
> >> > "%pR to [bus %02x-%02x] add_size %lx\n", b_res,
> >> > bus->secondary, bus->subordinate, size1-size0);
> >> > @@ -875,6 +878,8 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask,
> >> > min_align = align1 >> 1;
> >> > align += aligns[order];
> >> > }
> >> > +
> >> > + min_align = max(min_align, window_alignment(bus, type));
> >>
> >> 'type' can sometimes be (IORESOURCE_MEM | IORESOURCE_PREFETCH), which
> >> can lead to unpredictable results depending on how window_alignment()
> >> is implemented... Hence to be on the safer side I suggest
> >>
> >> min_align = max(min_align, window_alignment(bus, b_res->flags & mask));
>
> Sorry, Ram. I didn't see your concern in last reply. So I have to
> cover your conver in this reply.
>
> I think it'd better to pass "type" directly because platform (e.g. powernv)
> expects both IORESOURCE_MEM as well as IORESOURCE_PREFETCH.
> In future, powernv platform will return M32 segment size for IORESOURCE_MEM, but
> might return M64 segment size for (IORESOURCE_MEM | IORESOURCE_PREFETCH).
Hmm.. this code is not about determining what kind of segment the
platform is returning. This code is about using the right alignment
constraints for the type of segment from which resource will be
allocated. right?
b_res is the resource that is being sized. b_res already knows
what kind of resource it is, i.e IORESOURCE_MEM or IORESOURCE_PREFETCH.
Hence we should be exactly using the same alignment constraints as
that dictated by the type of b_res. no?
RP
next prev parent reply other threads:[~2012-07-17 5:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1342491799-30303-1-git-send-email-shangw@linux.vnet.ibm.com>
2012-07-17 3:40 ` [PATCH v6 0/7] minimal alignment for p2p bars Ram Pai
[not found] ` <1342491799-30303-6-git-send-email-shangw@linux.vnet.ibm.com>
2012-07-17 5:05 ` [PATCH 05/15] pci: resource assignment based on p2p alignment Ram Pai
2012-07-17 5:23 ` Ram Pai
[not found] ` <20120717053648.GA18497@shangw>
2012-07-17 5:57 ` Ram Pai [this message]
2012-07-17 9:16 ` Benjamin Herrenschmidt
2012-07-17 10:03 ` Ram Pai
2012-07-17 10:38 ` Benjamin Herrenschmidt
2012-07-17 17:14 ` Bjorn Helgaas
2012-07-18 4:25 ` Ram Pai
2012-07-18 16:59 ` Bjorn Helgaas
2012-07-19 7:24 ` Gavin Shan
[not found] ` <20120718010746.GA4238@shangw>
2012-07-18 5:02 ` Ram Pai
2012-07-18 4:28 ` Ram Pai
2012-06-29 6:47 [PATCH V5 0/7] minimal alignment for p2p bars Gavin Shan
[not found] ` <1342452631-21152-5-git-send-email-shangw@linux.vnet.ibm.com>
2012-07-17 0:47 ` [PATCH 05/15] pci: resource assignment based on p2p alignment Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717055715.GF2369@ram-ThinkPad-T61 \
--to=linuxram@us$(echo .)ibm.com \
--cc=bhelgaas@google$(echo .)com \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=shangw@linux$(echo .)vnet.ibm.com \
--cc=yinghai@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox