From: Oleg Nesterov <oleg@redhat•com>
To: Ananth N Mavinakayanahalli <ananth@in•ibm.com>
Cc: Srikar Dronamraju <srikar@linux•vnet.ibm.com>,
peterz@infradead•org, lkml <linux-kernel@vger•kernel.org>,
Paul Mackerras <paulus@samba•org>,
Anton Blanchard <anton@samba•org>, Ingo Molnar <mingo@elte•hu>,
ppcdev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc
Date: Wed, 22 Aug 2012 17:55:21 +0200 [thread overview]
Message-ID: <20120822155521.GA3993@redhat.com> (raw)
In-Reply-To: <20120822082708.GB29216@in.ibm.com>
On 08/22, Ananth N Mavinakayanahalli wrote:
>
> +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, unsigned long addr)
> +{
> + unsigned int insn;
> +
> + if (addr & 0x03)
> + return -EINVAL;
> +
> + memcpy(&insn, auprobe->insn, MAX_UINSN_BYTES);
> + if (is_trap(insn))
> + return -ENOTSUPP;
This addresses the only concern I had, thanks.
Once again, I am in no position to review the powerpc code, but
since I made some noise before: I think the patch is fine.
Oleg.
next prev parent reply other threads:[~2012-08-22 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 8:22 [PATCH 1/2] powerpc: Add trap_nr to thread_struct Ananth N Mavinakayanahalli
2012-08-22 8:27 ` [PATCH v4 2/2] powerpc: Uprobes port to powerpc Ananth N Mavinakayanahalli
2012-08-22 15:55 ` Oleg Nesterov [this message]
2012-08-23 4:28 ` Michael Ellerman
2012-08-23 5:32 ` Srikar Dronamraju
2012-08-23 10:06 ` Benjamin Herrenschmidt
2012-08-23 9:02 ` Oleg Nesterov
2012-08-23 16:02 ` Srikar Dronamraju
2012-08-23 16:17 ` Srikar Dronamraju
2012-08-23 21:57 ` Benjamin Herrenschmidt
2012-08-24 1:33 ` Michael Ellerman
2012-08-23 5:58 ` Ananth N Mavinakayanahalli
2012-08-24 1:13 ` Michael Ellerman
2012-08-24 7:07 ` Benjamin Herrenschmidt
2012-08-24 7:37 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822155521.GA3993@redhat.com \
--to=oleg@redhat$(echo .)com \
--cc=ananth@in$(echo .)ibm.com \
--cc=anton@samba$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=srikar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox