From: Greg KH <greg@kroah•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: linux-usb@vger•kernel.org,
"linuxppc-dev@lists•ozlabs.org list"
<linuxppc-dev@lists•ozlabs.org>,
Shengzhou Liu <Shengzhou.Liu@freescale•com>
Subject: Re: [PATCH v2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock
Date: Tue, 18 Sep 2012 15:34:28 +0100 [thread overview]
Message-ID: <20120918143428.GE15432@kroah.com> (raw)
In-Reply-To: <6E81CB63-79F1-4C45-87A6-28048351FF84@kernel.crashing.org>
On Tue, Sep 18, 2012 at 12:35:09AM -0500, Kumar Gala wrote:
>
> On Aug 22, 2012, at 5:17 AM, Shengzhou Liu wrote:
>
> > when missing USB PHY clock, kernel booting up will hang during USB
> > initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid
> > CPU hanging in this case.
> >
> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale•com>
> > ---
> > v2 changes: use spin_event_timeout() instead.
> >
> > drivers/usb/host/ehci-fsl.c | 58 +++++++++++++++++++++++++++++-------------
> > drivers/usb/host/ehci-fsl.h | 1 +
> > include/linux/fsl_devices.h | 1 +
> > 3 files changed, 42 insertions(+), 18 deletions(-)
>
> Greg,
>
> Any issues picking this fix up for v3.6 inclusion?
Yes, I will not as there is a v3 out there that I want some review on
before I can take it...
thanks,
greg k-h
prev parent reply other threads:[~2012-09-18 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 10:17 [PATCH v2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock Shengzhou Liu
2012-09-18 5:35 ` Kumar Gala
2012-09-18 9:31 ` Liu Shengzhou-B36685
2012-09-18 14:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918143428.GE15432@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=Shengzhou.Liu@freescale$(echo .)com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox