From: Greg KH <greg@kroah•com>
To: Liu Shengzhou-B36685 <B36685@freescale•com>
Cc: "linux-usb@vger•kernel.org" <linux-usb@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v3] powerpc/usb: fix bug of CPU hang when missing USB PHY clock
Date: Mon, 24 Sep 2012 10:27:52 -0700 [thread overview]
Message-ID: <20120924172752.GC32691@kroah.com> (raw)
In-Reply-To: <3F453DDFF675A64A89321A1F352810217FFC51@039-SN1MPN1-004.039d.mgd.msft.net>
On Mon, Sep 24, 2012 at 02:44:19PM +0000, Liu Shengzhou-B36685 wrote:
>
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah•com]
> > Sent: 2012年9月22日 22:49
> > To: Kumar Gala
> > Cc: Liu Shengzhou-B36685; linuxppc-dev@lists•ozlabs.org; linux-
> > usb@vger•kernel.org
> > Subject: Re: [PATCH v3] powerpc/usb: fix bug of CPU hang when missing
> > USB PHY clock
> >
> > On Sat, Sep 22, 2012 at 09:39:15AM -0500, Kumar Gala wrote:
> > >
> > > On Sep 21, 2012, at 11:43 AM, Greg KH wrote:
> > >
> > > > On Tue, Sep 18, 2012 at 04:52:39PM +0800, Shengzhou Liu wrote:
> > > >> when missing USB PHY clock, kernel booting up will hang during USB
> > > >> initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid
> > > >> CPU hanging in this case.
> > > >>
> > > >> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale•com>
> > > >> ---
> > > >> v3 change: no check for UTMI PHY.
> > > >> v2 change: use spin_event_timeout() instead.
> > > >>
> > > >> drivers/usb/host/ehci-fsl.c | 57 +++++++++++++++++++++++++++++--
> > -----------
> > > >> drivers/usb/host/ehci-fsl.h | 1 +
> > > >> include/linux/fsl_devices.h | 1 +
> > > >> 3 files changed, 41 insertions(+), 18 deletions(-)
> > > >
> > > > This is already applied, right?
> > > >
> > > > greg k-h
> > >
> > > It appears that v2 of the patch is applied to your usb-next branch.
> > >
> > > in drivers/usb/host/ehci-fsl.c
> > >
> > > V2:
> > > @@ -262,23 +266,34 @@ static void ehci_fsl_setup_phy(struct usb_hcd
> > *hcd,
> > > case FSL_USB2_PHY_NONE:
> > > break;
> > > }
> > > +
> > > + if ((pdata->controller_ver) && ((phy_mode ==
> > FSL_USB2_PHY_ULPI) ||
> > > + (phy_mode == FSL_USB2_PHY_UTMI))) {
> > >
> > > V3:
> > >
> > > @@ -262,23 +266,33 @@ static void ehci_fsl_setup_phy(struct usb_hcd
> > *hcd,
> > >
> > > case FSL_USB2_PHY_NONE:
> > > break;
> > > }
> > >
> > > +
> > > + if (pdata->controller_ver && (phy_mode == FSL_USB2_PHY_ULPI)) {
> > > + /* check PHY_CLK_VALID to get phy clk valid */
> >
> > Ok, can someone please make the incremental patch that I need to apply
> > here and send it to me?
> >
> > thanks,
> >
> > greg k-h
>
> Hi greg,
>
> I have sent the below incremental patch to you, please squash it into the previous patch v2, which had been applied in your usb-next branch.
> http://patchwork.ozlabs.org/patch/186443/
Given that this is a git tree, "squashing" patches does not work at all.
I'll just apply it as-is.
thanks,
greg k-h
prev parent reply other threads:[~2012-09-24 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 8:52 [PATCH v3] powerpc/usb: fix bug of CPU hang when missing USB PHY clock Shengzhou Liu
2012-09-21 16:43 ` Greg KH
2012-09-22 14:39 ` Kumar Gala
2012-09-22 14:48 ` Greg KH
2012-09-24 14:44 ` Liu Shengzhou-B36685
2012-09-24 17:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924172752.GC32691@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=B36685@freescale$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox