From: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
To: Josh Boyer <jwboyer@gmail•com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] PPC: Enable the Watchdog vector for 405
Date: Mon, 1 Oct 2012 10:25:47 -0600 [thread overview]
Message-ID: <20121001162547.GD31620@obsidianresearch.com> (raw)
In-Reply-To: <CA+5PVA767HNZUoFNj=UubLCdh91EtWiuK2JaY2qarMn=oCCB+A@mail.gmail.com>
On Mon, Oct 01, 2012 at 08:16:29AM -0400, Josh Boyer wrote:
> On Sun, Sep 30, 2012 at 7:27 PM, Jason Gunthorpe
> <jgunthorpe@obsidianresearch•com> wrote:
> > Move the body of the PIT exception out of line to make room.
>
> What boards did you test this on? What driver are you using for the
> watchdog?
Tested on a 405F6 core (Xilinx's variant), the board is custom, and
the control for the watchdog SPRs was bundled into a watchdog driver
for the board's watchdog controller.
> > /* 0x1010 - Fixed Interval Timer (FIT) Exception
> > */
> > - STND_EXCEPTION(0x1010, FITException, unknown_exception)
> > +// STND_EXCEPTION(0x1010, FITException, unknown_exception)
>
> Please just move the #endif for the #if 0 up instead of putting a C++
> style comment here.
Sure
> > /* 0x1020 - Watchdog Timer (WDT) Exception
> > */
> > -#ifdef CONFIG_BOOKE_WDT
> > CRITICAL_EXCEPTION(0x1020, WDTException, WatchdogException)
> > -#else
> > - CRITICAL_EXCEPTION(0x1020, WDTException, unknown_exception)
> > -#endif
> > -#endif
>
> Please leave this wrapped in CONFIG_BOOKE_WDT. I don't agree with
> unconditionally enabling this for every 405 chip out there.
What are you concerned with? If some core varient does not put a
watchdog there, then you still get a panic from the default watchdog
exception handler..
> > -#ifdef CONFIG_BOOKE_WDT
> > +#if defined(CONFIG_BOOKE_WDT) | defined(CONFIG_40x)
>
> Pretty sure you meant || here? Thought if you just enable the existing
> config option, I don't think you'd need to edit this file at all.
Yes, I didn't want to use BOOKE_WDT because I have not tested that
driver, nor do I want that driver included in my kernel.. I think the
watchdog driver in use should be orthogonal to having the exception
wired in?
Jason
next prev parent reply other threads:[~2012-10-01 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 23:27 [PATCH] PPC: Enable the Watchdog vector for 405 Jason Gunthorpe
2012-10-01 12:16 ` Josh Boyer
2012-10-01 16:25 ` Jason Gunthorpe [this message]
2012-10-01 17:32 ` Josh Boyer
2012-10-01 17:48 ` Jason Gunthorpe
2012-10-04 11:05 ` Benjamin Herrenschmidt
2012-10-05 18:07 ` [PATCHv2] " Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001162547.GD31620@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch$(echo .)com \
--cc=jwboyer@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox