From: Wolfram Sang <w.sang@pengutronix•de>
To: linuxppc-dev@ozlabs•org
Cc: John Bonesio <bones@secretlab•ca>, Anatolij Gustschin <agust@denx•de>
Subject: Re: [PATCH v2] powerpc: 52xx: nop out unsupported critical IRQs
Date: Sat, 20 Oct 2012 08:54:42 +0200 [thread overview]
Message-ID: <20121020065442.GA4208@pengutronix.de> (raw)
In-Reply-To: <1349947155-11540-1-git-send-email-w.sang@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]
On Thu, Oct 11, 2012 at 11:19:15AM +0200, Wolfram Sang wrote:
> Currently, when booting MPC52xx based platforms, we get:
>
> mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3
> irq: irq-16==>hwirq-0x3 mapping failed: -22
> [WARNing skipped]
>
> The warning is wrong since the mapping itself is valid. However, there is no
> support for that type of IRQ currently. Print a proper warning and bind the irq
> to a no_irq chip.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix•de>
> Cc: John Bonesio <bones@secretlab•ca>
> Cc: Anatolij Gustschin <agust@denx•de>
> Cc: Grant Likely <grant.likely@secretlab•ca>
Ping. I'd really like to get rid of the WARNing for all MPC52xx boards.
It looks pretty scary to people who don't know the issues behind it.
> ---
>
> Change since V1: drop the default state since all possibilities for l1 are now
> covered in the switch-statement.
>
> arch/powerpc/platforms/52xx/mpc52xx_pic.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> index 8520b58..b89ef65 100644
> --- a/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> +++ b/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> @@ -372,10 +372,11 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq,
> case MPC52xx_IRQ_L1_MAIN: irqchip = &mpc52xx_main_irqchip; break;
> case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break;
> case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break;
> - default:
> - pr_err("%s: invalid irq: virq=%i, l1=%i, l2=%i\n",
> - __func__, virq, l1irq, l2irq);
> - return -EINVAL;
> + case MPC52xx_IRQ_L1_CRIT:
> + pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n",
> + __func__, l2irq);
> + irq_set_chip(virq, &no_irq_chip);
> + return 0;
> }
>
> irq_set_chip_and_handler(virq, irqchip, handle_level_irq);
> --
> 1.7.10.4
>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-20 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 20:56 [PATCH] powerpc: 52xx: nop out unsupported critical IRQs Wolfram Sang
2012-10-11 9:19 ` [PATCH v2] " Wolfram Sang
2012-10-20 6:54 ` Wolfram Sang [this message]
2012-10-20 11:59 ` Anatolij Gustschin
2012-11-03 14:26 ` Wolfram Sang
2012-11-03 15:29 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121020065442.GA4208@pengutronix.de \
--to=w.sang@pengutronix$(echo .)de \
--cc=agust@denx$(echo .)de \
--cc=bones@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox