From: Sebastian Andrzej Siewior <sebastian@breakpoint•cc>
To: Kim Phillips <kim.phillips@freescale•com>
Cc: linux-usb@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
Shengzhou Liu <Shengzhou.Liu@freescale•com>
Subject: Re: [PATCH] powerpc/usb: fix build warning
Date: Wed, 24 Oct 2012 16:01:32 +0200 [thread overview]
Message-ID: <20121024140132.GB4368@breakpoint.cc> (raw)
In-Reply-To: <20121008164731.75483b961a01e824731c552b@freescale.com>
> index 9bfde82..968f751 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -222,7 +222,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
>
> if (pdata->controller_ver < 0) {
> dev_warn(hcd->self.controller, "Could not get controller version\n");
> - return;
> + return -EINVAL;
> }
>
> portsc = ehci_readl(ehci, &ehci->regs->port_status[port_offset]);
Another patch (USB: ehci-fsl: Return valid error in ehci_fsl_setup_phy)
by-passed Greg and went via Linus into tree and is available in v3.7-rc2.
Sebastian
prev parent reply other threads:[~2012-10-24 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 21:47 [PATCH] powerpc/usb: fix build warning Kim Phillips
2012-10-24 14:01 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024140132.GB4368@breakpoint.cc \
--to=sebastian@breakpoint$(echo .)cc \
--cc=Shengzhou.Liu@freescale$(echo .)com \
--cc=kim.phillips@freescale$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox