From: Felipe Balbi <balbi@ti•com>
To: Xiaotian Feng <xtfeng@gmail•com>
Cc: Xiaotian Feng <dannyfeng@tencent•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-usb@vger•kernel.org, linux-kernel@vger•kernel.org,
Felipe Balbi <balbi@ti•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill
Date: Wed, 31 Oct 2012 15:26:50 +0200 [thread overview]
Message-ID: <20121031132650.GP10998@arwen.pp.htv.fi> (raw)
In-Reply-To: <1351670761-26749-2-git-send-email-xtfeng@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]
On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote:
> If tasklet_disable() is called before related tasklet handled,
> tasklet_kill will never be finished. tasklet_kill is enough.
how did you test this ? Why changing FSL driver instead of switching
over to chipidea which is supposed to be shared by every licensee of the
chipidea core ?
> Signed-off-by: Xiaotian Feng <dannyfeng@tencent•com>
> Cc: Li Yang <leoli@freescale•com>
> Cc: Felipe Balbi <balbi@ti•com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Cc: linux-usb@vger•kernel.org
> Cc: linuxppc-dev@lists•ozlabs.org
> ---
> drivers/usb/gadget/fsl_qe_udc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c
> index b09452d..4ad3b82 100644
> --- a/drivers/usb/gadget/fsl_qe_udc.c
> +++ b/drivers/usb/gadget/fsl_qe_udc.c
> @@ -2661,7 +2661,7 @@ static int __devexit qe_udc_remove(struct platform_device *ofdev)
> usb_del_gadget_udc(&udc->gadget);
>
> udc->done = &done;
> - tasklet_disable(&udc->rx_tasklet);
> + tasklet_kill(&udc->rx_tasklet);
>
> if (udc->nullmap) {
> dma_unmap_single(udc->gadget.dev.parent,
> @@ -2698,8 +2698,6 @@ static int __devexit qe_udc_remove(struct platform_device *ofdev)
> free_irq(udc->usb_irq, udc);
> irq_dispose_mapping(udc->usb_irq);
>
> - tasklet_kill(&udc->rx_tasklet);
> -
> iounmap(udc->usb_regs);
>
> device_unregister(&udc->gadget.dev);
> --
> 1.7.9.5
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-31 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1351670761-26749-1-git-send-email-xtfeng@gmail.com>
2012-10-31 8:06 ` [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill Xiaotian Feng
2012-10-31 13:26 ` Felipe Balbi [this message]
2012-10-31 14:35 ` Li Yang
2012-10-31 14:34 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031132650.GP10998@arwen.pp.htv.fi \
--to=balbi@ti$(echo .)com \
--cc=dannyfeng@tencent$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=xtfeng@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox