From: Jiri Olsa <jolsa@redhat•com>
To: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello•nl>,
robert.richter@amd•com, Anton Blanchard <anton@au1•ibm.com>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Ingo Molnar <mingo@redhat•com>, Paul Mackerras <paulus@samba•org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols•net>
Subject: Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs
Date: Wed, 14 Nov 2012 11:25:34 +0100 [thread overview]
Message-ID: <20121114102534.GA2220@krava.brq.redhat.com> (raw)
In-Reply-To: <20121107191927.GC16211@us.ibm.com>
On Wed, Nov 07, 2012 at 11:19:28AM -0800, Sukadev Bhattiprolu wrote:
SNIP
> +struct perf_pmu_events_attr {
> + struct device_attribute attr;
> + u64 id;
> +};
> +
> +extern ssize_t power_events_sysfs_show(struct device *dev,
> + struct device_attribute *attr, char *page);
> +
> +#define EVENT_VAR(_id) event_attr_##_id
> +#define EVENT_PTR(_id) &event_attr_##_id.attr.attr
> +
> +#define EVENT_ATTR(_name, _id) \
> + static struct perf_pmu_events_attr EVENT_VAR(_id) = { \
> + .attr = __ATTR(_name, 0444, power_events_sysfs_show, NULL),\
> + .id = PM_##_id, \
> + };
this is duplicating the x86 code, perhaps it could be moved
to include/linux/perf_event.h and shared globaly
> diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
> index aa2465e..19b23bd 100644
> --- a/arch/powerpc/perf/core-book3s.c
> +++ b/arch/powerpc/perf/core-book3s.c
> @@ -1305,6 +1305,16 @@ static int power_pmu_event_idx(struct perf_event *event)
> return event->hw.idx;
> }
>
> +ssize_t power_events_sysfs_show(struct device *dev,
> + struct device_attribute *attr, char *page)
> +{
> + struct perf_pmu_events_attr *pmu_attr;
> +
> + pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);
> +
> + return sprintf(page, "event=0x%02llx\n", pmu_attr->id);
whitespace issues
jirka
next prev parent reply other threads:[~2012-11-14 10:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 19:18 [PATCH 1/4] perf/powerpc: Use uapi/unistd.h to fix build error Sukadev Bhattiprolu
2012-11-07 19:18 ` [PATCH 2/4] perf/Power7: Use macros to identify perf events Sukadev Bhattiprolu
2012-11-07 19:19 ` [PATCH 3/4] perf/POWER7: Make event translations available in sysfs Sukadev Bhattiprolu
2012-11-14 10:25 ` Jiri Olsa [this message]
2012-11-14 18:20 ` Sukadev Bhattiprolu
2012-11-16 12:51 ` Jiri Olsa
2012-11-16 19:35 ` Sukadev Bhattiprolu
2012-11-19 20:34 ` Jiri Olsa
2012-11-07 19:19 ` [PATCH 4/4] perf: Create a sysfs entry for Power event format Sukadev Bhattiprolu
2012-11-14 10:27 ` Jiri Olsa
2012-11-20 10:43 ` [PATCH 1/4] perf/powerpc: Use uapi/unistd.h to fix build error Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114102534.GA2220@krava.brq.redhat.com \
--to=jolsa@redhat$(echo .)com \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=acme@ghostprotocols$(echo .)net \
--cc=anton@au1$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=robert.richter@amd$(echo .)com \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox