From: Thierry Reding <thierry.reding@avionic-design•de>
To: Andrew Murray <andrew.murray@arm•com>
Cc: Michal Simek <monstr@monstr•eu>,
"linux-pci@vger•kernel.org" <linux-pci@vger•kernel.org>,
devicetree-discuss <devicetree-discuss@lists•ozlabs.org>,
Liviu Dudau <Liviu.Dudau@arm•com>,
"rob.herring@calxeda•com" <rob.herring@calxeda•com>,
Rob Herring <robherring2@gmail•com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] pci: Provide support for parsing PCI DT ranges property
Date: Thu, 13 Dec 2012 11:03:18 +0100 [thread overview]
Message-ID: <20121213100318.GB13055@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20121213094543.GA23446@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2154 bytes --]
On Thu, Dec 13, 2012 at 09:45:43AM +0000, Andrew Murray wrote:
> On Thu, Dec 13, 2012 at 09:13:33AM +0000, Thierry Reding wrote:
> > Hi Andrew,
> >
> > I don't like iterator interfaces too much, but I can live with that.
> > Other than that the patch looks good to me and I'll try to work it into
> > my Tegra PCIe patch series.
> >
> > Just two minor comments below.
> >
> > > diff --git a/drivers/of/address.c b/drivers/of/address.c
> > [...]
> > > @@ -421,7 +472,7 @@ u64 __of_translate_address(struct device_node *dev, const __be32 *in_addr,
> > > goto bail;
> > > bus = of_match_bus(parent);
> > >
> > > - /* Cound address cells & copy address locally */
> > > + /* Count address cells & copy address locally */
> > > bus->count_cells(dev, &na, &ns);
> > > if (!OF_CHECK_COUNTS(na, ns)) {
> > > printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
> >
> > This is really minor, but it should still go into a separate patch.
> >
> > > diff --git a/include/linux/of_address.h b/include/linux/of_address.h
> > > index 01b925a..4582b20 100644
> > > --- a/include/linux/of_address.h
> > > +++ b/include/linux/of_address.h
> > > @@ -26,6 +26,8 @@ static inline unsigned long pci_address_to_pio(phys_addr_t addr) { return -1; }
> > > #define pci_address_to_pio pci_address_to_pio
> > > #endif
> > >
> > > +const __be32 *of_pci_process_ranges(struct device_node *node,
> > > + struct resource *res, const __be32 *from);
> > > #else /* CONFIG_OF_ADDRESS */
> > > static inline int of_address_to_resource(struct device_node *dev, int index,
> > > struct resource *r)
> > > @@ -48,6 +50,11 @@ static inline const u32 *of_get_address(struct device_node *dev, int index,
> > > {
> > > return NULL;
> > > }
> > > +const __be32 *of_pci_process_ranges(struct device_node *node,
> >
> > There should be a blank line to separate the above two lines.
> >
>
> Thanks for the feedback.
>
> I will send another patch for the typo and leave this patch with you for
> working into your existing series.
I suppose you have your own series that uses this patch?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-13 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 16:37 [PATCH] pci: Provide support for parsing PCI DT ranges property Andrew Murray
2012-12-13 9:13 ` Thierry Reding
2012-12-13 9:45 ` Andrew Murray
2012-12-13 10:03 ` Thierry Reding [this message]
2012-12-13 10:34 ` Andrew Murray
2012-12-15 1:06 ` Grant Likely
2013-01-14 9:24 ` Andrew Murray
2012-12-20 8:25 ` Thierry Reding
2013-01-14 9:15 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213100318.GB13055@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design$(echo .)de \
--cc=Liviu.Dudau@arm$(echo .)com \
--cc=andrew.murray@arm$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=monstr@monstr$(echo .)eu \
--cc=rob.herring@calxeda$(echo .)com \
--cc=robherring2@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox