From: Felipe Balbi <balbi@ti•com>
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: r58472@freescale•com, gregkh@linuxfoundation•org,
linux-usb@vger•kernel.org, balbi@ti•com,
Peter Chen <peter.chen@freescale•com>,
kernel@pengutronix•de, shawn.guo@linaro•org,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id
Date: Mon, 14 Jan 2013 12:24:44 +0200 [thread overview]
Message-ID: <20130114102444.GD10874@arwen.pp.htv.fi> (raw)
In-Reply-To: <50F3DB8D.6050104@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote:
> On 01/14/2013 11:16 AM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote:
> >> @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct device *dev)
> >>
> >> return fsl_udc_resume(NULL);
> >> }
> >> -
> >> /*-------------------------------------------------------------------------
> >> Register entry point for the peripheral controller driver
> >> --------------------------------------------------------------------------*/
> >> -
> >> +static const struct platform_device_id fsl_udc_devtype[] = {
> >> + {
> >> + .name = "imx-udc-mx25",
> >> + .driver_data = IMX25_UDC,
> >> + }, {
> >> + .name = "imx-udc-mx27",
> >> + .driver_data = IMX27_UDC,
> >> + }, {
> >> + .name = "imx-udc-mx31",
> >> + .driver_data = IMX31_UDC,
> >> + }, {
> >> + .name = "imx-udc-mx35",
> >> + .driver_data = IMX35_UDC,
> >> + }, {
> >> + .name = "imx-udc-mx51",
> >> + .driver_data = IMX51_UDC,
> >> + }
> >> +};
> >
> > I wonder if your driver-data is actually needed since you can use string
> > comparisson to achieve the exact same outcome.
>
> Why use a string compare, if the kernel infrastructure already does this
> for you?
what do you mean ? What kernel infrastructure is doing waht for me ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-14 10:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 10:12 [PATCH v3 0/3] Fix the Build error for fsl_mxc_udc.c Peter Chen
2013-01-14 10:12 ` [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id Peter Chen
2013-01-14 10:16 ` Felipe Balbi
2013-01-14 10:18 ` Marc Kleine-Budde
2013-01-14 10:24 ` Felipe Balbi [this message]
2013-01-14 10:34 ` Marc Kleine-Budde
2013-01-14 10:39 ` Felipe Balbi
2013-01-14 10:50 ` Marc Kleine-Budde
2013-01-14 10:53 ` Felipe Balbi
2013-01-14 11:03 ` Marc Kleine-Budde
2013-01-14 11:06 ` Felipe Balbi
2013-01-14 12:56 ` Peter Chen
2013-01-14 17:40 ` Felipe Balbi
2013-01-14 17:54 ` Marc Kleine-Budde
2013-01-14 17:57 ` Felipe Balbi
2013-01-15 1:31 ` Peter Chen
2013-01-14 10:12 ` [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap Peter Chen
2013-01-14 10:17 ` Felipe Balbi
2013-01-14 12:58 ` Peter Chen
2013-01-14 13:10 ` Russell King - ARM Linux
2013-01-14 13:16 ` Peter Chen
2013-01-14 10:12 ` [PATCH v3 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114102444.GD10874@arwen.pp.htv.fi \
--to=balbi@ti$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mkl@pengutronix$(echo .)de \
--cc=peter.chen@freescale$(echo .)com \
--cc=r58472@freescale$(echo .)com \
--cc=shawn.guo@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox