From: Wolfram Sang <wsa@the-dreams•de>
To: Doug Anderson <dianders@chromium•org>
Cc: "Tony Lindgren" <tony@atomide•com>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Thierry Reding" <thierry.reding@avionic-design•de>,
"Sekhar Nori" <nsekhar@ti•com>,
linux-i2c@vger•kernel.org, "Guan Xuetao" <gxt@mprc•pku.edu.cn>,
"Kevin Hilman" <khilman@ti•com>,
"Sonic Zhang" <sonic.zhang@analog•com>,
linux-arm-kernel@lists•infradead.org,
"Deepak Sikri" <deepak.sikri@st•com>,
"Havard Skinnemoen" <hskinnemoen@gmail•com>,
"Marek Vasut" <marex@denx•de>, "Pawel Moll" <pawel.moll@arm•com>,
"Stephen Warren" <swarren@wwwdotorg•org>,
"Sascha Hauer" <s.hauer@pengutronix•de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
"Rob Herring" <rob.herring@calxeda•com>,
uclinux-dist-devel@blackfin•uclinux.org,
"Jean Delvare" <khali@linux-fr•org>,
"Lars-Peter Clausen" <lars@metafoo•de>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff•org>,
"Barry Song" <baohua.song@csr•com>,
linux-omap@vger•kernel.org,
"Mika Westerberg" <mika.westerberg@linux•intel.com>,
"Oskar Schirmer" <oskar@scara•com>,
"Fabio Estevam" <fabio.estevam@freescale•com>,
davinci-linux-open-source@linux•davincidsp.com,
"Shawn Guo" <shawn.guo@linaro•org>,
"Jim Cromie" <jim.cromie@gmail•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Tomoya MORINAGA" <tomoya.rohm@gmail•com>,
linux-kernel@vger•kernel.org,
"Kyungmin Park" <kyungmin.park@samsung•com>,
"Viresh Kumar" <viresh.linux@gmail•com>,
"Karol Lewandowski" <k.lewandowsk@samsung•com>,
"Jiri Kosina" <jkosina@suse•cz>,
STEricsson <STEricsson_nomadik_linux@list•st.com>,
"Joe Perches" <joe@perches•com>,
"Andrew Morton" <akpm@linux-foundation•org>,
"Alessandro Rubini" <rubini@unipv•it>,
linuxppc-dev@lists•ozlabs.org,
"Alexander Stein" <alexander.stein@systec-electronic•com>
Subject: Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls
Date: Thu, 21 Feb 2013 11:48:10 +0100 [thread overview]
Message-ID: <20130221104810.GD22806@the-dreams.de> (raw)
In-Reply-To: <1360970315-32116-1-git-send-email-dianders@chromium.org>
On Fri, Feb 15, 2013 at 03:18:35PM -0800, Doug Anderson wrote:
> There is simply no reason to be manually setting the private driver
> data to NULL in the remove/fail to probe cases. This is just extra
> cruft code that can be removed.
>
> A few notes:
> * Nothing relies on drvdata being set to NULL.
> * The __device_release_driver() function eventually calls
> dev_set_drvdata(dev, NULL) anyway, so there's no need to do it
> twice.
> * I verified that there were no cases where xxx_get_drvdata() was
> being called in these drivers and checking for / relying on the NULL
> return value.
>
> This could be cleaned up kernel-wide but for now just take the baby
> step and remove from the i2c subsystem.
>
> Reported-by: Wolfram Sang <wsa@the-dreams•de>
> Reported-by: Stephen Warren <swarren@wwwdotorg•org>
> Signed-off-by: Doug Anderson <dianders@chromium•org>
Applied, thanks!
prev parent reply other threads:[~2013-02-21 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1360953682-25066-1-git-send-email-dianders@chromium.org>
2013-02-15 23:18 ` [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls Doug Anderson
2013-02-16 19:52 ` Jean Delvare
2013-02-17 15:12 ` Peter Korsgaard
2013-02-18 10:35 ` Mika Westerberg
2013-02-18 12:17 ` Marek Vasut
2013-02-21 10:48 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221104810.GD22806@the-dreams.de \
--to=wsa@the-dreams$(echo .)de \
--cc=STEricsson_nomadik_linux@list$(echo .)st.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.stein@systec-electronic$(echo .)com \
--cc=baohua.song@csr$(echo .)com \
--cc=ben-linux@fluff$(echo .)org \
--cc=davinci-linux-open-source@linux$(echo .)davincidsp.com \
--cc=deepak.sikri@st$(echo .)com \
--cc=dianders@chromium$(echo .)org \
--cc=fabio.estevam@freescale$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gxt@mprc$(echo .)pku.edu.cn \
--cc=hskinnemoen@gmail$(echo .)com \
--cc=jim.cromie@gmail$(echo .)com \
--cc=jkosina@suse$(echo .)cz \
--cc=joe@perches$(echo .)com \
--cc=k.lewandowsk@samsung$(echo .)com \
--cc=khali@linux-fr$(echo .)org \
--cc=khilman@ti$(echo .)com \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=lars@metafoo$(echo .)de \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=marex@denx$(echo .)de \
--cc=mika.westerberg@linux$(echo .)intel.com \
--cc=nsekhar@ti$(echo .)com \
--cc=oskar@scara$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=rob.herring@calxeda$(echo .)com \
--cc=rubini@unipv$(echo .)it \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@linaro$(echo .)org \
--cc=sonic.zhang@analog$(echo .)com \
--cc=swarren@wwwdotorg$(echo .)org \
--cc=thierry.reding@avionic-design$(echo .)de \
--cc=tomoya.rohm@gmail$(echo .)com \
--cc=tony@atomide$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
--cc=viresh.linux@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox