From: Michael Ellerman <michael@ellerman•id.au>
To: Brian King <brking@linux•vnet.ibm.com>
Cc: klebers@linux•vnet.ibm.com, linux-pci@vger•kernel.org,
bhelgaas@google•com, linuxppc-dev@lists•ozlabs.org,
lucaskt@linux•vnet.ibm.com
Subject: Re: [PATCH 3/3] powerpc: Set default VGA device
Date: Fri, 5 Apr 2013 17:52:38 +1100 [thread overview]
Message-ID: <20130405065238.GC5082@concordia> (raw)
In-Reply-To: <201304042158.r34LwGPg010714@d03av02.boulder.ibm.com>
Hi Brian,
On Thu, Apr 04, 2013 at 04:58:17PM -0500, Brian King wrote:
>
> Add a PCI quirk for VGA devices on Power to set the default VGA device.
> Ensures a default VGA is always set if a graphics adapter is present,
> even if firmware did not initialize it. If more than one graphics
> adapter is present, ensure the one initialized by firmware is set
> as the default VGA device. This ensures that X autoconfiguration
> will work.
So a few things:
- You are doing this on all power systems, not just pseries which is I
assume what you're testing on - that seems OK to me, but just
checking.
- What is the "initialized by firmware" test? Just that IO & MEM are
enabled?
- You potentially override an existing default, is that a problem? Can
the user set the default? (no AFAICS).
- The x86 code is slightly different, they don't override an existing
default, why do we?
cheers
next prev parent reply other threads:[~2013-04-05 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 21:58 [PATCH 3/3] powerpc: Set default VGA device Brian King
2013-04-05 6:52 ` Michael Ellerman [this message]
2013-04-05 15:38 ` Brian King
2013-04-05 20:24 ` Bjorn Helgaas
2013-04-08 5:21 ` Michael Ellerman
2013-04-08 6:39 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405065238.GC5082@concordia \
--to=michael@ellerman$(echo .)id.au \
--cc=bhelgaas@google$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=klebers@linux$(echo .)vnet.ibm.com \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lucaskt@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox