From: Michael Ellerman <michael@ellerman•id.au>
To: Li Zhong <zhong@linux•vnet.ibm.com>
Cc: fweisbec@gmail•com, paulmck@linux•vnet.ibm.com, paulus@samba•org,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC PATCH v2 6/6] powerpc: Use generic code for exception handling
Date: Wed, 10 Apr 2013 14:56:59 +1000 [thread overview]
Message-ID: <20130410045659.GB15929@concordia> (raw)
In-Reply-To: <1364551221-23177-7-git-send-email-zhong@linux.vnet.ibm.com>
On Fri, Mar 29, 2013 at 06:00:21PM +0800, Li Zhong wrote:
> After the exception handling moved to generic code, and some changes in
...
> diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
> index 360fba8..eeab30f 100644
> --- a/arch/powerpc/mm/hash_utils_64.c
> +++ b/arch/powerpc/mm/hash_utils_64.c
> @@ -33,6 +33,7 @@
> #include <linux/init.h>
> #include <linux/signal.h>
> #include <linux/memblock.h>
> +#include <linux/context_tracking.h>
>
> #include <asm/processor.h>
> #include <asm/pgtable.h>
> @@ -56,7 +57,6 @@
> #include <asm/fadump.h>
> #include <asm/firmware.h>
> #include <asm/tm.h>
> -#include <asm/context_tracking.h>
>
> #ifdef DEBUG
> #define DBG(fmt...) udbg_printf(fmt)
> @@ -919,13 +919,17 @@ int hash_page(unsigned long ea, unsigned long access, unsigned long trap)
> const struct cpumask *tmp;
> int rc, user_region = 0, local = 0;
> int psize, ssize;
> + enum ctx_state prev_state;
> +
> + prev_state = exception_enter();
>
> DBG_LOW("hash_page(ea=%016lx, access=%lx, trap=%lx\n",
> ea, access, trap);
>
> if ((ea & ~REGION_MASK) >= PGTABLE_RANGE) {
> DBG_LOW(" out of pgtable range !\n");
> - return 1;
> + rc = 1;
> + goto exit;
> }
>
> /* Get region & vsid */
This no longer applies on mainline, please send an updated version.
cheers
next prev parent reply other threads:[~2013-04-10 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 10:00 [RFC PATCH v2 0/6] powerpc: Support context tracking for Power pSeries Li Zhong
2013-03-29 10:00 ` [RFC PATCH v2 1/6] powerpc: Syscall hooks for context tracking subsystem Li Zhong
2013-03-29 10:00 ` [RFC PATCH v2 2/6] powerpc: Exception " Li Zhong
2013-04-05 2:50 ` Paul Mackerras
2013-04-08 9:03 ` Li Zhong
2013-03-29 10:00 ` [RFC PATCH v2 3/6] powerpc: Exit user context on notify resume Li Zhong
2013-03-29 10:00 ` [RFC PATCH v2 4/6] powerpc: Use the new schedule_user API on userspace preemption Li Zhong
2013-03-29 10:00 ` [RFC PATCH v2 5/6] powerpc: select HAVE_CONTEXT_TRACKING for pSeries Li Zhong
2013-03-29 10:00 ` [RFC PATCH v2 6/6] powerpc: Use generic code for exception handling Li Zhong
2013-04-10 4:56 ` Michael Ellerman [this message]
2013-04-10 5:32 ` Li Zhong
2013-04-10 5:56 ` Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410045659.GB15929@concordia \
--to=michael@ellerman$(echo .)id.au \
--cc=fweisbec@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=zhong@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox