From: "Paul E. McKenney" <paulmck@linux•vnet.ibm.com>
To: Paul Mackerras <paulus@samba•org>
Cc: Lai Jiangshan <laijs@cn•fujitsu.com>,
Gleb Natapov <gleb@redhat•com>,
Marcelo Tosatti <mtosatti@redhat•com>,
Alexander Graf <agraf@suse•de>,
kvm-ppc@vger•kernel.org, linux-kernel@vger•kernel.org,
kvm@vger•kernel.org, Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock()
Date: Thu, 11 Apr 2013 14:51:29 -0700 [thread overview]
Message-ID: <20130411215129.GU29861@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130317212648.GA4259@iris.ozlabs.ibm.com>
On Mon, Mar 18, 2013 at 08:26:48AM +1100, Paul Mackerras wrote:
> On Sat, Mar 16, 2013 at 12:50:49AM +0800, Lai Jiangshan wrote:
> > At the point of up_out label in kvmppc_hv_setup_htab_rma(),
> > srcu read lock is still held.
> >
> > We have to release it before return.
> >
> > Signed-off-by: Lai Jiangshan <laijs@cn•fujitsu.com>
> > Cc: Marcelo Tosatti <mtosatti@redhat•com>
> > Cc: Gleb Natapov <gleb@redhat•com>
> > Cc: Alexander Graf <agraf@suse•de>
> > Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > Cc: Paul Mackerras <paulus@samba•org>
> > Cc: kvm@vger•kernel.org
> > Cc: kvm-ppc@vger•kernel.org
> > ---
> > arch/powerpc/kvm/book3s_hv.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> > index 80dcc53..c26740e 100644
> > --- a/arch/powerpc/kvm/book3s_hv.c
> > +++ b/arch/powerpc/kvm/book3s_hv.c
> > @@ -1799,7 +1799,7 @@ static int kvmppc_hv_setup_htab_rma(struct kvm_vcpu *vcpu)
> >
> > up_out:
> > up_read(¤t->mm->mmap_sem);
> > - goto out;
> > + goto out_srcu;
>
> Acked-by: Paul Mackerras <paulus@samba•org>
Thank you both, queued for 3.11 (assuming no one has beat me to it).
Thanx, Paul
prev parent reply other threads:[~2013-04-11 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1363366257-4886-1-git-send-email-laijs@cn.fujitsu.com>
2013-03-15 16:50 ` [PATCH 1/9] powerpc,kvm: fix imbalance srcu_read_[un]lock() Lai Jiangshan
2013-03-17 21:26 ` Paul Mackerras
2013-04-11 21:51 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411215129.GU29861@linux.vnet.ibm.com \
--to=paulmck@linux$(echo .)vnet.ibm.com \
--cc=agraf@suse$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=gleb@redhat$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=laijs@cn$(echo .)fujitsu.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mtosatti@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox