From: Guenter Roeck <linux@roeck-us•net>
To: Chen Yuanquan-B41889 <B41889@freescale•com>
Cc: Yuanquan Chen <Yuanquan.Chen@freescale•com>,
Hiroo Matsumoto <matsumoto.hiroo@jp•fujitsu.com>,
linux-kernel@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc/pci: Improve device hotplug initialization
Date: Sun, 2 Jun 2013 21:11:42 -0700 [thread overview]
Message-ID: <20130603041142.GA11874@roeck-us.net> (raw)
In-Reply-To: <51ABFF5F.4020409@freescale.com>
On Mon, Jun 03, 2013 at 10:28:47AM +0800, Chen Yuanquan-B41889 wrote:
> On 06/01/2013 09:58 PM, Guenter Roeck wrote:
> >On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote:
> >>On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote:
> >>>On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote:
> >>>>On 05/29/2013 01:35 AM, Guenter Roeck wrote:
> >>>>>bios_add_device(). Drop explicit calls to pcibios_setup_device();
> >>>>>this makes pcibios_setup_bus_devices() a noop function which could
> >>>>>eve
> >>>>Yeah, it's more reasonable to do the irq and DMA related initialization
> >>>>in one code path for all devices.
> >>>>
> >>>Any comments / feedback on the code itself ?
> >>Sorry, I haven't had a chance to review it yet, I'm fairly bogged down
> >>at the moment. I want to tread carefully because the previous iteration
> >>of changing that stuff did break a few platforms in the end.
> >>
> >Hi Ben,
> >
> >the comment was actuially directed towards Yuanquan.
> >
> >No problem, take your time. I did my best to test it, but I agree that this is a
> >critical area of the code, and it would be desirable to get additional scrutiny
> >and test feedback.
> >
> >The code has been running in our system (P2020 and P5040) for several months.
> >I was preparing a patch for upstream submission when I noticed commit 37f02195b.
> >After testing ithis commit, I noticed the problems with it and wrote this patch,
> >which aligns the code with our initial patch. I tested it as good as I could on
> >our systems as well as with a P5040 evaluation board and an Intel GE PCIe
> >card.
> >
> >Thanks,
> >Guenter
> >
>
> Hi Guenter,
>
> Your patch makes sure the initialization of DMA and irq in one code
> path and also
> avoids the initialization called two times(in pci bus scanning and
> pci_enable_device()
> in device driver) for no-hot-plugged pci device. It's much more reasonable!
>
> I don't know why you also remove the function "set_dev_node()" ? As
> I know, the
> function just be called here. I think it should remain in your new function
> pcibios_add_device().
>
pcibios_add_device() is (only) called from pci_device_add(),
which already calls set_dev_node().
Guenter
next prev parent reply other threads:[~2013-06-03 4:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:35 [PATCH] powerpc/pci: Improve device hotplug initialization Guenter Roeck
2013-05-29 9:30 ` Chen Yuanquan-B41889
2013-05-31 5:14 ` Guenter Roeck
2013-05-31 5:44 ` Benjamin Herrenschmidt
2013-06-01 13:58 ` Guenter Roeck
2013-06-03 2:28 ` Chen Yuanquan-B41889
2013-06-03 4:11 ` Guenter Roeck [this message]
2013-06-06 1:00 ` Benjamin Herrenschmidt
2013-06-06 5:25 ` Guenter Roeck
2013-06-06 5:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603041142.GA11874@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=B41889@freescale$(echo .)com \
--cc=Yuanquan.Chen@freescale$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=matsumoto.hiroo@jp$(echo .)fujitsu.com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox