From: Michael Ellerman <michael@ellerman•id.au>
To: Nathan Fontenot <nfont@linux•vnet.ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] Do not update sysfs cpu registration from invalid context
Date: Tue, 25 Jun 2013 11:50:57 +1000 [thread overview]
Message-ID: <20130625015057.GC14051@concordia> (raw)
In-Reply-To: <51C8543F.6080905@linux.vnet.ibm.com>
On Mon, Jun 24, 2013 at 09:14:23AM -0500, Nathan Fontenot wrote:
> The topology update code that updates the cpu node registration in sysfs
> should not be called while in stop_machine(). The register/unregister
> calls take a lock and may sleep.
>
> This patch moves these calls outside of the call to stop_machine().
What happens? Do we lockup or do you just get a warning?
And what commit introduced the breakage?
cheers
next prev parent reply other threads:[~2013-06-25 1:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 14:14 [PATCH] Do not update sysfs cpu registration from invalid context Nathan Fontenot
2013-06-24 17:18 ` Seth Jennings
2013-06-24 19:16 ` Seth Jennings
2013-06-24 19:25 ` Nathan Fontenot
2013-06-25 1:50 ` Michael Ellerman
2013-06-25 2:46 ` Nathan Fontenot
2013-06-25 1:50 ` Michael Ellerman [this message]
2013-06-25 2:47 ` Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625015057.GC14051@concordia \
--to=michael@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nfont@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox