From: Michael Ellerman <michael@ellerman•id.au>
To: Kevin Hao <haokexin@gmail•com>
Cc: linuxppc <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c
Date: Wed, 10 Jul 2013 13:25:33 +1000 [thread overview]
Message-ID: <20130710032533.GA10374@concordia> (raw)
In-Reply-To: <20130710022307.GB361@pek-khao-d1.corp.ad.wrs.com>
On Wed, Jul 10, 2013 at 10:23:07AM +0800, Kevin Hao wrote:
> On Wed, Jul 10, 2013 at 12:01:33PM +1000, Michael Ellerman wrote:
> > On Wed, Jul 10, 2013 at 09:43:42AM +0800, Kevin Hao wrote:
> > > The math.c is only built when CONFIG_MATH_EMULATION is enabled.
> > > So we would never get into the case that CONFIG_MATH_EMULATION
> > > is not defined in this file.
> >
> > Any idea why we have that there? ie. have the config symbols changed
> > over time or was this always dead code?
>
> No idea. I tried to trace this before submitting the patch. But it has
> been there since the begin of the git history. So I just assume that it is
> always dead code. :-)
Yeah looks like it. Even in the git-huge tree I see it in the initial
commit.
You should say that in the commit message though. Otherwise it's not
clear if you're fixing a recent breakage or not.
cheers
next prev parent reply other threads:[~2013-07-10 3:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 1:43 [PATCH 0/2] powerpc/math-emu: two minor cleanup patches for math.c Kevin Hao
2013-07-10 1:43 ` [PATCH 1/2] powerpc/math-emu: remove the dead code in math.c Kevin Hao
2013-07-10 2:01 ` Michael Ellerman
2013-07-10 2:23 ` Kevin Hao
2013-07-10 3:25 ` Michael Ellerman [this message]
2013-07-10 3:46 ` Kevin Hao
2013-07-10 3:48 ` Benjamin Herrenschmidt
2013-07-10 1:43 ` [PATCH 2/2] powerpc/math-emu: remove the unneeded check for CONFIG_MATH_EMULATION " Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710032533.GA10374@concordia \
--to=michael@ellerman$(echo .)id.au \
--cc=haokexin@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox