From: Matt Helsley <matthltc@linux•vnet.ibm.com>
To: Kevin Hao <haokexin@gmail•com>
Cc: Scott Wood <scottwood@freescale•com>,
linuxppc <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/math-emu: move the flush FPU state function into do_mathemu
Date: Thu, 11 Jul 2013 17:34:45 -0700 [thread overview]
Message-ID: <20130712003445.GC14599@us.ibm.com> (raw)
In-Reply-To: <1373545315-9219-2-git-send-email-haokexin@gmail.com>
On Thu, Jul 11, 2013 at 08:21:54PM +0800, Kevin Hao wrote:
> By doing this we can make sure that the FPU state is only flushed to
> the thread struct when it is really needed.
>
> Signed-off-by: Kevin Hao <haokexin@gmail•com>
> ---
> arch/powerpc/kernel/traps.c | 9 ---------
> arch/powerpc/math-emu/math.c | 9 +++++++++
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index bf33c22..58a8065 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -1131,15 +1131,6 @@ void __kprobes program_check_exception(struct pt_regs *regs)
> * instruction or only on FP instructions, whether there is a
> * pattern to occurrences etc. -dgibson 31/Mar/2003
> */
> -
> - /*
> - * If we support a HW FPU, we need to ensure the FP state
> - * if flushed into the thread_struct before attempting
> - * emulation
> - */
> -#ifdef CONFIG_PPC_FPU
> - flush_fp_to_thread(current);
> -#endif
> switch (do_mathemu(regs)) {
> case 0:
> emulate_single_step(regs);
> diff --git a/arch/powerpc/math-emu/math.c b/arch/powerpc/math-emu/math.c
> index 3fe8e35..18ce6a7 100644
> --- a/arch/powerpc/math-emu/math.c
> +++ b/arch/powerpc/math-emu/math.c
> @@ -420,6 +420,15 @@ do_mathemu(struct pt_regs *regs)
> goto illegal;
> }
>
> + /*
> + * If we support a HW FPU, we need to ensure the FP state
> + * if flushed into the thread_struct before attempting
As long as you're moving the comment you could fix up the spelling
error: s/if/is/
Cheers,
-Matt Helsley
next prev parent reply other threads:[~2013-07-12 20:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:21 [PATCH 0/2] powerpc/math-emu: two patches for the emulation of the FPU unimplemented instructions Kevin Hao
2013-07-11 12:21 ` [PATCH 1/2] powerpc/math-emu: move the flush FPU state function into do_mathemu Kevin Hao
2013-07-12 0:34 ` Matt Helsley [this message]
2013-07-14 8:11 ` Kevin Hao
2013-07-11 12:21 ` [PATCH 2/2] powerpc/math-emu: keep track of the instructions unimplemented by FPU Kevin Hao
2013-07-11 12:45 ` Benjamin Herrenschmidt
2013-07-11 14:30 ` Scott Wood
2013-07-12 2:25 ` Kevin Hao
2013-07-12 20:53 ` Scott Wood
2013-07-12 23:05 ` Benjamin Herrenschmidt
2013-07-12 2:07 ` Kevin Hao
2013-07-12 3:56 ` Benjamin Herrenschmidt
2013-07-12 5:05 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712003445.GC14599@us.ibm.com \
--to=matthltc@linux$(echo .)vnet.ibm.com \
--cc=haokexin@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox