Subject: Re: [1/4] powerpc/85xx: Add SEC6.0 device tree

From: Scott Wood <[email-masked]>
Date: Mon, 22 Jul 2013 17:41:10 -0500

On Thu, Apr 25, 2013 at 09:54:14AM +0800, Po Liu wrote:
> From: Mingkai Hu <[email-masked]>
> 
> Add device tree for SEC 6.0 used on C29x silicon.
> 
> Signed-off-by: Mingkai Hu <[email-masked]>
> Singed-off-by: Po Liu <[email-masked]>

I've heard of patches being flamed, but here we want signing, not
singeing. :-)

Don't forget that you can use the -s option to have git add the signoff
for you.

> ---
> Base on git://git.am.freescale.net/gitolite/mirrors/linux-2.6.git

This URL is not accessible outside Freescale, so don't reference it when
posting patches publicly.

If your patch is against the latest upstream code, you don't need to say
anything special about that.  You only need to make a note when it's
against some other yet-to-be-merged tree or patch.

> +	compatible = "fsl,sec-v6.0", "fsl,sec-v5.2",
> +		     "fsl,sec-v5.0", "fsl,sec-v4.4",
> +		     "fsl,sec-v4.0";
> +	fsl,sec-era = <6>;
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +
> +	jr@1000 {
> +		compatible = "fsl,sec-v6.0-job-ring",
> +			     "fsl,sec-v5.2-job-ring",
> +			     "fsl,sec-v5.0-job-ring",
> +			     "fsl,sec-v4.4-job-ring",
> +			     "fsl,sec-v4.0-job-ring";
> +		reg	   = <0x1000 0x1000>;
> +	};
> +
> +	jr@2000 {
> +		compatible = "fsl,sec-v6.0-job-ring",
> +			     "fsl,sec-v5.2-job-ring",
> +			     "fsl,sec-v5.0-job-ring",
> +			     "fsl,sec-v4.4-job-ring",
> +			     "fsl,sec-v4.0-job-ring";
> +		reg	   = <0x2000 0x1000>;
> +	};

You claim compatibility with a bunch of prior SECs, but sec-v5.2 has four
job rings and an rtic node.  Likewise for the previous compatibles
listed.  This has two job rings and no rtic.

Can you point to where in the SEC v4.0 binding (I don't see a binding for
the subsequent versions), it says that these are optional?

-Scott