From: Scott Wood <scottwood@freescale•com>
To: Dongsheng Wang <dongsheng.wang@freescale•com>
Cc: chenhui.zhao@freescale•com, rjw@sisk•pl, paulus@samba•org,
johannes@sipsolutions•net, avorontsov@ru•mvista.com,
linuxppc-dev@lists•ozlabs.org
Subject: Re: powerpc/mpc85xx: fix non-bootcpu cannot up after hibernation resume
Date: Wed, 7 Aug 2013 19:34:59 -0500 [thread overview]
Message-ID: <20130808003459.GA3964@home.buserror.net> (raw)
In-Reply-To: <1368518756-9850-1-git-send-email-dongsheng.wang@freescale.com>
On Tue, May 14, 2013 at 04:05:56PM +0800, Dongsheng Wang wrote:
> This problem belongs to the core synchronization issues.
> The cpu1 already updated spin_table values, but bootcore cannot get
> this value in time.
>
> After bootcpu hibiernation restore the pages. we are now running
> with the kernel data of the old kernel fully restored. if we reset
> the non-bootcpus that will be reset cache(tlb), the non-bootcpus
> will get new address(map virtual and physical address spaces).
> but bootcpu tlb cache still use boot kernel data, so we need to
> invalidate the bootcpu tlb cache make it to get new main memory data.
>
> log:
> Enabling non-boot CPUs ...
> smp_85xx_kick_cpu: timeout waiting for core 1 to reset
> smp: failed starting cpu 1 (rc -2)
> Error taking CPU1 up: -2
>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale•com>
> Reviewed-by: Anton Vorontsov <anton@enomsg•org>
>
>
> diff --git a/arch/powerpc/kernel/swsusp_booke.S b/arch/powerpc/kernel/swsusp_booke.S
> index 11a3930..9503249 100644
> --- a/arch/powerpc/kernel/swsusp_booke.S
> +++ b/arch/powerpc/kernel/swsusp_booke.S
> @@ -141,6 +141,19 @@ _GLOBAL(swsusp_arch_resume)
> lis r11,swsusp_save_area@h
> ori r11,r11,swsusp_save_area@l
>
> + /*
> + * The boot core get a virtual address, when the boot process,
> + * the virtual address corresponds to a physical address. After
> + * hibernation resume memory snapshots, The corresponding
> + * relationship between the virtual memory and physical memory
> + * might change again. We need to get a new page table. So we
> + * need to invalidate TLB after resume pages.
> + *
> + * Invalidations TLB Using tlbilx/tlbivax/MMUCSR0.
> + * tlbilx used here.
> + */
> + bl _tlbil_all
Applied with the code comment changed to:
/*
* Mappings from virtual addresses to physical addresses may be
* different than they were prior to restoring hibernation state.
* Invalidate the TLB so that the boot CPU is using the new
* mappings.
*/
-Scott
prev parent reply other threads:[~2013-08-08 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 8:05 [PATCH] powerpc/mpc85xx: fix non-bootcpu cannot up after hibernation resume Wang Dongsheng
2013-05-14 8:59 ` Wang Dongsheng-B40534
2013-05-23 17:33 ` Anton Vorontsov
2013-05-24 5:21 ` Wang Dongsheng-B40534
2013-06-09 8:23 ` Wang Dongsheng-B40534
2013-08-08 0:34 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130808003459.GA3964@home.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=chenhui.zhao@freescale$(echo .)com \
--cc=dongsheng.wang@freescale$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=rjw@sisk$(echo .)pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox