From: Nicolin Chen <b42378@freescale•com>
To: Mark Rutland <mark.rutland@arm•com>
Cc: "devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>,
"lars@metafoo•de" <lars@metafoo•de>,
"swarren@wwwdotorg•org" <swarren@wwwdotorg•org>,
"festevam@gmail•com" <festevam@gmail•com>,
"s.hauer@pengutronix•de" <s.hauer@pengutronix•de>,
"timur@tabi•org" <timur@tabi•org>,
"rob.herring@calxeda•com" <rob.herring@calxeda•com>,
"tomasz.figa@gmail•com" <tomasz.figa@gmail•com>,
"broonie@kernel•org" <broonie@kernel•org>,
"p.zabel@pengutronix•de" <p.zabel@pengutronix•de>,
"R65777@freescale•com" <R65777@freescale•com>,
"shawn.guo@linaro•org" <shawn.guo@linaro•org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Mon, 19 Aug 2013 17:34:24 +0800 [thread overview]
Message-ID: <20130819093423.GB10950@MrMyself> (raw)
In-Reply-To: <20130819091809.GD3719@e106331-lin.cambridge.arm.com>
Hi Mark,
Thank you for the commenst. I'll Fix them in v8.
Here are some remaining question:
On Mon, Aug 19, 2013 at 10:18:09AM +0100, Mark Rutland wrote:
> > +Required properties:
> > +
> > + - compatible : Compatible list, contains "fsl,<chip>-spdif".
>
> What are valid values for <chip>? The binding should mention this. There
> are bindings that don't, but they need to be fixed. Undocumented ABIs
> are a bad idea.
I see, so 'Compatible list, must contains "fsl,imx35-spdif"' would be okay?
> > + - interrupts : Contains spdif interrupt.
>
> Is that the only interrupt the device generates?
Yes, how could I improve this description?
> > + "core" The core clock of spdif controller
> > + "rxtx<0-7>" Clock source list for tx and rx clock.
> > + This clock list should be identical to
> > + the source list connecting to the spdif
> > + clock mux in "SPDIF Transceiver Clock
> > + Diagram" of SoC reference manual. It
> > + can also be referred to TxClk_Source
> > + bit of register SPDIF_STC.
>
> Could you elaborate on the last sentence? I'm not sure exactly what you
> meant.
The list is also identical to the TxClk_Source bit value list of
register SPDIF_STC.
>
> > +
> > +Example:
> > +
> > +spdif: spdif@02004000 {
> > + compatible = "fsl,imx6q-spdif",
> > + "fsl,imx35-spdif";
>
> Is "fsl,imx35-spdif" necessary in the list, or is it not the case all
> "fsl,<chip>-spdif" variants are compatible with it?
>
> That should be mentioned along with the list of valid compatible
> strings.
I guess it's better to drop the 'imx6q-spdif' here?
Thank you,
Nicolin
next prev parent reply other threads:[~2013-08-19 9:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 8:35 [PATCH v7 0/2] Add freescale S/PDIF CPU DAI and machine drivers Nicolin Chen
2013-08-19 8:35 ` [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Nicolin Chen
2013-08-19 9:18 ` Mark Rutland
2013-08-19 9:34 ` Nicolin Chen [this message]
2013-08-19 9:54 ` Mark Rutland
2013-08-19 10:13 ` Nicolin Chen
2013-08-19 11:13 ` Mark Rutland
2013-08-19 11:34 ` Nicolin Chen
2013-08-20 8:47 ` Mark Rutland
2013-08-20 5:19 ` Shawn Guo
2013-08-20 8:54 ` Mark Rutland
2013-08-20 16:28 ` Stephen Warren
2013-08-19 8:35 ` [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
2013-08-19 9:24 ` Mark Rutland
2013-08-19 9:50 ` Nicolin Chen
2013-08-19 10:01 ` Mark Rutland
2013-08-19 10:21 ` Nicolin Chen
2013-08-19 11:15 ` Mark Rutland
2013-08-19 10:27 ` Philipp Zabel
2013-08-19 10:52 ` Mark Brown
2013-08-19 11:31 ` Mark Rutland
2013-08-19 11:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819093423.GB10950@MrMyself \
--to=b42378@freescale$(echo .)com \
--cc=R65777@freescale$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=lars@metafoo$(echo .)de \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=rob.herring@calxeda$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@linaro$(echo .)org \
--cc=swarren@wwwdotorg$(echo .)org \
--cc=timur@tabi$(echo .)org \
--cc=tomasz.figa@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox