From: Nicolin Chen <b42378@freescale•com>
To: Mark Rutland <mark.rutland@arm•com>
Cc: "devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>,
"lars@metafoo•de" <lars@metafoo•de>,
"swarren@wwwdotorg•org" <swarren@wwwdotorg•org>,
"festevam@gmail•com" <festevam@gmail•com>,
"s.hauer@pengutronix•de" <s.hauer@pengutronix•de>,
"timur@tabi•org" <timur@tabi•org>,
"rob.herring@calxeda•com" <rob.herring@calxeda•com>,
"tomasz.figa@gmail•com" <tomasz.figa@gmail•com>,
"broonie@kernel•org" <broonie@kernel•org>,
"p.zabel@pengutronix•de" <p.zabel@pengutronix•de>,
"R65777@freescale•com" <R65777@freescale•com>,
"shawn.guo@linaro•org" <shawn.guo@linaro•org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Mon, 19 Aug 2013 18:13:04 +0800 [thread overview]
Message-ID: <20130819101303.GB11402@MrMyself> (raw)
In-Reply-To: <20130819095433.GG3719@e106331-lin.cambridge.arm.com>
On Mon, Aug 19, 2013 at 10:54:33AM +0100, Mark Rutland wrote:
> > I see, so 'Compatible list, must contains "fsl,imx35-spdif"' would be okay?
>
> While that needs to be mentioned, other values which might be present
> (e.g. "fsl,imx6q-spdif") must be mentioned, or we can't rely on them
> if we want to use them in future from drivers to provide additional
> information (and thus they're useless).
Well, imx6q-spdif is identical to the imx35-spdif. So I think the
'must contains 35' would be enough for the current case. If any
future modification happens to the list, I can update this doc later.
> >
> > > > + - interrupts : Contains spdif interrupt.
> > >
> > > Is that the only interrupt the device generates?
> >
> > Yes, how could I improve this description?
>
> It's probably not possible to make it much clearar to be honest,
> "Contains the sole interrupt generated by the device" might be a little
> overkill.
Then I keep it no-change :)
> > > > + "rxtx<0-7>" Clock source list for tx and rx clock.
> > > > + This clock list should be identical to
> > > > + the source list connecting to the spdif
> > > > + clock mux in "SPDIF Transceiver Clock
> > > > + Diagram" of SoC reference manual. It
> > > > + can also be referred to TxClk_Source
> > > > + bit of register SPDIF_STC.
> > The list is also identical to the TxClk_Source bit value list of
> > register SPDIF_STC.
>
> What I don't understand is how the value of the SPDIF_STC register
> within the spdif IP block can describe the necessary details of clocks
> coming from an external clock provider.
>
> What do the TxClk_Source bits represent? The configuration of the clock
> inputs on the spdif IP block, or the outputs on some clock provider? Are
> they writeable, or configured at integration time? If the clock provider
> were replaced with another arbitrary clock provider, what would they
> represent?
Actually there's a clock mux for TxClk and it's connecting with 8 clock
sources. So the TxClk_Source bit show the connection between its value
with the correspond source on the clock mux:
TxClk_Source 000 XTAL clk input
001 CCM spdif0_clk_root input
010 asrc_clk input
011 spdif_extclk input, from pads
100 esai_hckt input
101 frequency divided ipg_clk input
110 mlb_clk input
111 mlb phy clk input
> > I guess it's better to drop the 'imx6q-spdif' here?
>
> That depends:
>
> * If the two IP blocks are identical, only the "imx35-spdif" name is
> necessary, and we can forget about "fsl,imx6q-spdif".
>
> * If "fsl,imx6q-spdif" is a strict superset of "fsl,imx35-spdif", having
> both names documented and in a compatible list for a "fsl,imx6q-spdif"
> device makes sense.
>
> * If "fsl,imx6q-spdif" is a variation of "fsl,imx35-spdif", and the
> "fsl,imx6q-spdif" cannot always be treated identically to a
> "fsl,imx35-spdif", then it makes sense to have separate compatible
> strings, with a device being listed as either "fsl,imx6q-spdif" or
> "fsl,imx35-spdif".
>
> I don't know enough about the hardware to make that judgement call.
Thank you for explaining! I will choose A, because they are internally
identical except their external clock sources.
Best regards,
Nicolin
next prev parent reply other threads:[~2013-08-19 10:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 8:35 [PATCH v7 0/2] Add freescale S/PDIF CPU DAI and machine drivers Nicolin Chen
2013-08-19 8:35 ` [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Nicolin Chen
2013-08-19 9:18 ` Mark Rutland
2013-08-19 9:34 ` Nicolin Chen
2013-08-19 9:54 ` Mark Rutland
2013-08-19 10:13 ` Nicolin Chen [this message]
2013-08-19 11:13 ` Mark Rutland
2013-08-19 11:34 ` Nicolin Chen
2013-08-20 8:47 ` Mark Rutland
2013-08-20 5:19 ` Shawn Guo
2013-08-20 8:54 ` Mark Rutland
2013-08-20 16:28 ` Stephen Warren
2013-08-19 8:35 ` [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
2013-08-19 9:24 ` Mark Rutland
2013-08-19 9:50 ` Nicolin Chen
2013-08-19 10:01 ` Mark Rutland
2013-08-19 10:21 ` Nicolin Chen
2013-08-19 11:15 ` Mark Rutland
2013-08-19 10:27 ` Philipp Zabel
2013-08-19 10:52 ` Mark Brown
2013-08-19 11:31 ` Mark Rutland
2013-08-19 11:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819101303.GB11402@MrMyself \
--to=b42378@freescale$(echo .)com \
--cc=R65777@freescale$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=lars@metafoo$(echo .)de \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=rob.herring@calxeda$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@linaro$(echo .)org \
--cc=swarren@wwwdotorg$(echo .)org \
--cc=timur@tabi$(echo .)org \
--cc=tomasz.figa@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox