Subject: Re: [PATCH v3] powerpc/kernel/sysfs: cleanup set up macros for PMC/non-PMC SPRs

From: Michael Ellerman <[email-masked]>
Date: Tue, 8 Oct 2013 15:17:02 +1100

On Thu, Oct 03, 2013 at 02:57:35PM +0530, Madhavan Srinivasan wrote:
> Currently PMC (Performance Monitor Counter) setup macros are used
> for other SPRs. Since not all SPRs are PMC related, this patch
> modifies the exisiting macro and uses it to setup both PMC and
> non PMC SPRs accordingly.
> 
> V3 changes:
> 
> 1) No logic change, just renamed generic macro and removed #define for empty string
> 2) Changes in the comment to explain better.
> 
> V2 changes:
> 
> 1) Modified SYSFS_PMCSETUP to a generic macro with additional parameter
> 2) Added PMC and SPR macro to call the generic macro
> 3) Changes in the comment to explain better.
> 
> Signed-off-by: Madhavan Srinivasan <[email-masked]>

Acked-by: Michael Ellerman <[email-masked]>

Thanks for putting up with all the bike-shedding.

cheers