From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: Scott Wood <scottwood@freescale•com>,
"linuxppc-dev@lists•ozlabs.org list"
<linuxppc-dev@lists•ozlabs.org>,
Linux Kernel list <linux-kernel@vger•kernel.org>,
Xie Xiaobo <X.Xie@freescale•com>
Subject: Re: [PATCH] powerpc/qe_lib: Share the qe_lib for the others architecture
Date: Mon, 14 Oct 2013 13:09:52 -0700 [thread overview]
Message-ID: <20131014200952.GA20517@kroah.com> (raw)
In-Reply-To: <3F4D4A39-3063-45F5-8B0E-3CD5F36B4035@kernel.crashing.org>
On Mon, Oct 14, 2013 at 02:40:44PM -0500, Kumar Gala wrote:
>
> On Oct 14, 2013, at 2:26 PM, Kumar Gala wrote:
>
> >
> > On Oct 14, 2013, at 6:37 AM, Xie Xiaobo wrote:
> >
> >> The QUICC Engine (QE) is a communications coprocessors on Freescale
> >> embedded processors. The QE had been applied in PowerPC architecture
> >> previously, and it will be applied in ARM architecture too.
> >> So move the qe_lib from arch/powerpc to driver/ firstly.
> >>
> >> Signed-off-by: Xie Xiaobo <X.Xie@freescale•com>
> >> ---
> >> arch/powerpc/Kconfig | 2 -
> >> arch/powerpc/include/asm/immap_qe.h | 491 -----------------
> >> arch/powerpc/include/asm/qe.h | 740 -------------------------
> >> arch/powerpc/include/asm/qe_ic.h | 144 -----
> >> arch/powerpc/include/asm/ucc.h | 64 ---
> >> arch/powerpc/include/asm/ucc_fast.h | 244 --------
> >> arch/powerpc/include/asm/ucc_slow.h | 290 ----------
> >> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +-
> >> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 4 +-
> >> arch/powerpc/platforms/Kconfig | 19 -
> >> arch/powerpc/sysdev/Makefile | 1 -
> >> arch/powerpc/sysdev/qe_lib/Kconfig | 27 -
> >> arch/powerpc/sysdev/qe_lib/Makefile | 10 -
> >> arch/powerpc/sysdev/qe_lib/gpio.c | 317 -----------
> >> arch/powerpc/sysdev/qe_lib/qe.c | 708 ------------------------
> >> arch/powerpc/sysdev/qe_lib/qe_ic.c | 501 -----------------
> >> arch/powerpc/sysdev/qe_lib/qe_ic.h | 103 ----
> >> arch/powerpc/sysdev/qe_lib/qe_io.c | 218 --------
> >> arch/powerpc/sysdev/qe_lib/ucc.c | 213 -------
> >> arch/powerpc/sysdev/qe_lib/ucc_fast.c | 364 ------------
> >> arch/powerpc/sysdev/qe_lib/ucc_slow.c | 380 -------------
> >> arch/powerpc/sysdev/qe_lib/usb.c | 56 --
> >> drivers/Kconfig | 2 +
> >> drivers/Makefile | 3 +
> >> drivers/net/ethernet/freescale/fsl_pq_mdio.c | 2 +-
> >> drivers/net/ethernet/freescale/ucc_geth.c | 8 +-
> >> drivers/net/ethernet/freescale/ucc_geth.h | 8 +-
> >> drivers/qe/Kconfig | 51 ++
> >> drivers/qe/Makefile | 10 +
> >> drivers/qe/gpio.c | 317 +++++++++++
> >> drivers/qe/qe.c | 708 ++++++++++++++++++++++++
> >> drivers/qe/qe_common.c | 187 +++++++
> >> drivers/qe/qe_ic.c | 501 +++++++++++++++++
> >> drivers/qe/qe_ic.h | 103 ++++
> >> drivers/qe/qe_io.c | 218 ++++++++
> >> drivers/qe/ucc.c | 213 +++++++
> >> drivers/qe/ucc_fast.c | 364 ++++++++++++
> >> drivers/qe/ucc_slow.c | 380 +++++++++++++
> >> drivers/qe/usb.c | 56 ++
> >> drivers/spi/spi-fsl-cpm.c | 2 +-
> >> drivers/tty/serial/ucc_uart.c | 2 +-
> >> include/qe/immap_qe.h | 491 +++++++++++++++++
> >> include/qe/qe.h | 794 +++++++++++++++++++++++++++
> >> include/qe/qe_ic.h | 144 +++++
> >> include/qe/ucc.h | 64 +++
> >> include/qe/ucc_fast.h | 244 ++++++++
> >> include/qe/ucc_slow.h | 290 ++++++++++
> >> 47 files changed, 5155 insertions(+), 4907 deletions(-)
> >> delete mode 100644 arch/powerpc/include/asm/immap_qe.h
> >> delete mode 100644 arch/powerpc/include/asm/qe.h
> >> delete mode 100644 arch/powerpc/include/asm/qe_ic.h
> >> delete mode 100644 arch/powerpc/include/asm/ucc.h
> >> delete mode 100644 arch/powerpc/include/asm/ucc_fast.h
> >> delete mode 100644 arch/powerpc/include/asm/ucc_slow.h
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/Kconfig
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/Makefile
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/gpio.c
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/qe.c
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/qe_ic.c
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/qe_ic.h
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/qe_io.c
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/ucc.c
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/ucc_fast.c
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/ucc_slow.c
> >> delete mode 100644 arch/powerpc/sysdev/qe_lib/usb.c
> >> create mode 100644 drivers/qe/Kconfig
> >> create mode 100644 drivers/qe/Makefile
> >> create mode 100644 drivers/qe/gpio.c
> >> create mode 100644 drivers/qe/qe.c
> >> create mode 100644 drivers/qe/qe_common.c
> >> create mode 100644 drivers/qe/qe_ic.c
> >> create mode 100644 drivers/qe/qe_ic.h
> >> create mode 100644 drivers/qe/qe_io.c
> >> create mode 100644 drivers/qe/ucc.c
> >> create mode 100644 drivers/qe/ucc_fast.c
> >> create mode 100644 drivers/qe/ucc_slow.c
> >> create mode 100644 drivers/qe/usb.c
> >> create mode 100644 include/qe/immap_qe.h
> >> create mode 100644 include/qe/qe.h
> >> create mode 100644 include/qe/qe_ic.h
> >> create mode 100644 include/qe/ucc.h
> >> create mode 100644 include/qe/ucc_fast.h
> >> create mode 100644 include/qe/ucc_slow.h
> >
> > Before this is moved you should address the PPC specific issues in the code. Use of PPC_LIB_RHEAP, the IO macros which are not cross platform, etc.
> >
> > Also, copy linux-kernel list as I'm not sure drivers/qe would be the recommendation location for this to end up at.
>
> Greg,
>
> Wondering your thoughts on drivers/qe vs something like
> drivers/soc/fsl/qe. The QuiccEngine (qe) is a communication core on
> some of the Freescale networking SoCs that provides the ability to do
> various networking/communication functionality. "Channels" on the QE
> can be used for various different things from ethernet, ATM, UART, or
> other functions.
What makes the code "QE" specific? Are these devices that live on the
QE "bus", or are they controlling the QE controller?
It's hard to know what to do with code by just looking at a diffstat,
sorry.
> I've already commented that some of what is in qe_lib today needs to
> move to things like drivers/irqchip, drivers/pinctrl, drivers/gpio,
> etc. However, there will still be some qe specific code that doesn't
> have a natural home in drivers/ today.
Why not move it there now, instead of moving it twice? How will I know
the move will ever happen if we accept it this way "for now"?
greg k-h
next prev parent reply other threads:[~2013-10-14 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 11:37 [PATCH] powerpc/qe_lib: Share the qe_lib for the others architecture Xie Xiaobo
2013-10-14 17:11 ` Scott Wood
2013-10-14 19:26 ` Kumar Gala
2013-10-14 19:36 ` Kumar Gala
2013-10-14 19:40 ` Kumar Gala
2013-10-14 20:09 ` Greg Kroah-Hartman [this message]
2013-10-15 13:16 ` Gerhard Sittig
2013-10-16 18:12 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014200952.GA20517@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=X.Xie@freescale$(echo .)com \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox